hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

be2net: remove wrong and unnecessary calls to netif_carrier_off() 

1) In be_probe(), as soon as the MCC Q is created a gratuitous link status
event is received and processed. Accordingly netif_carrier_off/on() is called.
The extra netif_carrier_off() call in probe can race with this and cause wrong
state.

2) be_close() need not call netif_carrier_off(). It is OK to show the actual
link state even when the device is administratively down.

Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sathya Perla 2011-08-02 19:57:41 +00:00 committed by David S. Miller
parent a9b3cd7f32
commit d09f698056
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/benet/be_main.c
View File

@ -2217,7 +2217,6 @@ static int be_close(struct net_device *netdev)
be_async_mcc_disable(adapter); be_async_mcc_disable(adapter);
netif_carrier_off(netdev);
adapter->link_up = false; adapter->link_up = false;
if (!lancer_chip(adapter)) if (!lancer_chip(adapter))
@ -3345,7 +3344,6 @@ static int __devinit be_probe(struct pci_dev *pdev,
status = register_netdev(netdev); status = register_netdev(netdev);
if (status != 0) if (status != 0)
goto unsetup; goto unsetup;
netif_carrier_off(netdev);
if (be_physfn(adapter) && adapter->sriov_enabled) { if (be_physfn(adapter) && adapter->sriov_enabled) {
u8 mac_speed; u8 mac_speed;