hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net/smc: Make sure the link_id is unique 

The link_id is supposed to be unique, but smcr_next_link_id() doesn't
skip the used link_id as expected. So the patch fixes this.

Fixes: 026c381fb4 ("net/smc: introduce link_idx for link group array")
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wen Gu 2021-11-15 17:45:07 +08:00 committed by David S. Miller
parent 938cca9e41
commit cf4f5530bb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/smc/smc_core.c
View File

@ -708,13 +708,14 @@ static u8 smcr_next_link_id(struct smc_link_group *lgr)
int i; int i;
while (1) { while (1) {
again:
link_id = ++lgr->next_link_id; link_id = ++lgr->next_link_id;
if (!link_id) /* skip zero as link_id */ if (!link_id) /* skip zero as link_id */
link_id = ++lgr->next_link_id; link_id = ++lgr->next_link_id;
for (i = 0; i < SMC_LINKS_PER_LGR_MAX; i++) { for (i = 0; i < SMC_LINKS_PER_LGR_MAX; i++) {
if (smc_link_usable(&lgr->lnk[i]) && if (smc_link_usable(&lgr->lnk[i]) &&
lgr->lnk[i].link_id == link_id) lgr->lnk[i].link_id == link_id)
continue; goto again;
} }
break; break;
} }