hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

misc: pci_endpoint_test: Avoid using hard-coded BAR sizes 

BAR sizes are hard-coded in pci_endpoint_test driver corresponding to the
sizes used in pci-epf-test function driver. This might break if the sizes
in pci-epf-test function driver are modified (and the corresponding change
is not done in pci_endpoint_test PCI driver).

To avoid hard coding BAR sizes, use pci_resource_len() API.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Kishon Vijay Abraham I 2017-08-18 20:28:08 +05:30 committed by Bjorn Helgaas
parent 0b91516adc
commit cda370ec6d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/misc/pci_endpoint_test.c
View File

@ -100,8 +100,6 @@ struct pci_endpoint_test_data {
bool no_msi; bool no_msi;
}; };
static int bar_size[] = { 512, 512, 1024, 16384, 131072, 1048576 };
static inline u32 pci_endpoint_test_readl(struct pci_endpoint_test *test, static inline u32 pci_endpoint_test_readl(struct pci_endpoint_test *test,
u32 offset) u32 offset)
{ {
@ -149,11 +147,12 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
int j; int j;
u32 val; u32 val;
int size; int size;
struct pci_dev *pdev = test->pdev;
if (!test->bar[barno]) if (!test->bar[barno])
return false; return false;
size = bar_size[barno]; size = pci_resource_len(pdev, barno);
if (barno == test->test_reg_bar) if (barno == test->test_reg_bar)
size = 0x4; size = 0x4;