hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[SCSI] zfcp: fix module parameter parsing 

From: Heiko Carstens <heiko.carstens@de.ibm.com>

Fixes module parameter parsing for "device" parameter.  The original
module parameter was changed while parsing it.  This corrupted the
output in sysfs (/sys/module/zfcp/parameters/device).

Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
Andreas Herrmann 2005-06-13 13:22:25 +02:00 committed by James Bottomley
parent 1db2c9c093
commit cd8a383ebc
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/s390/scsi/zfcp_aux.c
View File

@ -218,13 +218,20 @@ zfcp_in_els_dbf_event(struct zfcp_adapter *adapter, const char *text,
* Parse "device=..." parameter string. * Parse "device=..." parameter string.
*/ */
static int __init static int __init
zfcp_device_setup(char *str) zfcp_device_setup(char *devstr)
{ {
char *tmp; char *tmp, *str;
size_t len;
if (!str) if (!devstr)
return 0; return 0;
len = strlen(devstr) + 1;
str = (char *) kmalloc(len, GFP_KERNEL);
if (!str)
goto err_out;
memcpy(str, devstr, len);
tmp = strchr(str, ','); tmp = strchr(str, ',');
if (!tmp) if (!tmp)
goto err_out; goto err_out;
@ -241,10 +248,12 @@ zfcp_device_setup(char *str)
zfcp_data.init_fcp_lun = simple_strtoull(tmp, &tmp, 0); zfcp_data.init_fcp_lun = simple_strtoull(tmp, &tmp, 0);
if (*tmp != '\0') if (*tmp != '\0')
goto err_out; goto err_out;
kfree(str);
return 1; return 1;
err_out: err_out:
ZFCP_LOG_NORMAL("Parse error for device parameter string %s\n", str); ZFCP_LOG_NORMAL("Parse error for device parameter string %s\n", str);
kfree(str);
return 0; return 0;
} }