hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

livepatch: Send a fake signal periodically 

An administrator may send a fake signal to all remaining blocking tasks
of a running transition by writing to
/sys/kernel/livepatch/<patch>/signal attribute. Let's do it
automatically after 15 seconds. The timeout is chosen deliberately. It
gives the tasks enough time to transition themselves.

Theoretically, sending it once should be more than enough. However,
every task must get outside of a patched function to be successfully
transitioned. It could prove not to be simple and resending could be
helpful in that case.

A new workqueue job could be a cleaner solution to achieve it, but it
could also introduce deadlocks and cause more headaches with
synchronization and cancelling.

[jkosina@suse.cz: removed added newline]
Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Miroslav Benes 2019-01-15 17:45:06 +01:00 committed by Jiri Kosina
parent a2818ee4dc
commit cba82dea30
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/livepatch/livepatch.txt
View File

@ -163,7 +163,8 @@ patched state. This may be harmful to the system though.
Writing 1 to the attribute sends a fake signal to all remaining blocking Writing 1 to the attribute sends a fake signal to all remaining blocking
tasks. No proper signal is actually delivered (there is no data in signal tasks. No proper signal is actually delivered (there is no data in signal
pending structures). Tasks are interrupted or woken up, and forced to change pending structures). Tasks are interrupted or woken up, and forced to change
their patched state. their patched state. Despite the sysfs attribute the fake signal is also sent
every 15 seconds automatically.
Administrator can also affect a transition through Administrator can also affect a transition through
/sys/kernel/livepatch/<patch>/force attribute. Writing 1 there clears /sys/kernel/livepatch/<patch>/force attribute. Writing 1 there clears

16
kernel/livepatch/transition.c
View File

@ -29,10 +29,14 @@
#define MAX_STACK_ENTRIES 100 #define MAX_STACK_ENTRIES 100
#define STACK_ERR_BUF_SIZE 128 #define STACK_ERR_BUF_SIZE 128
#define SIGNALS_TIMEOUT 15
struct klp_patch *klp_transition_patch; struct klp_patch *klp_transition_patch;
static int klp_target_state = KLP_UNDEFINED; static int klp_target_state = KLP_UNDEFINED;
static unsigned int klp_signals_cnt;
/* /*
* This work can be performed periodically to finish patching or unpatching any * This work can be performed periodically to finish patching or unpatching any
* "straggler" tasks which failed to transition in the first attempt. * "straggler" tasks which failed to transition in the first attempt.
@ -393,6 +397,10 @@ void klp_try_complete_transition(void)
put_online_cpus(); put_online_cpus();
if (!complete) { if (!complete) {
if (klp_signals_cnt && !(klp_signals_cnt % SIGNALS_TIMEOUT))
klp_send_signals();
klp_signals_cnt++;
/* /*
* Some tasks weren't able to be switched over. Try again * Some tasks weren't able to be switched over. Try again
* later and/or wait for other methods like kernel exit * later and/or wait for other methods like kernel exit
@ -454,6 +462,8 @@ void klp_start_transition(void)
if (task->patch_state != klp_target_state) if (task->patch_state != klp_target_state)
set_tsk_thread_flag(task, TIF_PATCH_PENDING); set_tsk_thread_flag(task, TIF_PATCH_PENDING);
} }
klp_signals_cnt = 0;
} }
/* /*
@ -578,14 +588,14 @@ void klp_copy_process(struct task_struct *child)
/* /*
* Sends a fake signal to all non-kthread tasks with TIF_PATCH_PENDING set. * Sends a fake signal to all non-kthread tasks with TIF_PATCH_PENDING set.
* Kthreads with TIF_PATCH_PENDING set are woken up. Only admin can request this * Kthreads with TIF_PATCH_PENDING set are woken up.
* action currently.
*/ */
void klp_send_signals(void) void klp_send_signals(void)
{ {
struct task_struct *g, *task; struct task_struct *g, *task;
pr_notice("signaling remaining tasks\n"); if (klp_signals_cnt == SIGNALS_TIMEOUT)
pr_notice("signaling remaining tasks\n");
read_lock(&tasklist_lock); read_lock(&tasklist_lock);
for_each_process_thread(g, task) { for_each_process_thread(g, task) {