net-sysfs: trigger netlink notification on ifalias change via sysfs
This patch adds netlink notifications on iflias changes via sysfs. makes it consistent with the netlink path which also calls netdev_state_change. Also makes it consistent with other sysfs netdev_store operations. Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com> Reviewed-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
6dc14dc40a
commit
c92eb77aff
|
@ -382,7 +382,7 @@ static ssize_t ifalias_store(struct device *dev, struct device_attribute *attr,
|
||||||
struct net_device *netdev = to_net_dev(dev);
|
struct net_device *netdev = to_net_dev(dev);
|
||||||
struct net *net = dev_net(netdev);
|
struct net *net = dev_net(netdev);
|
||||||
size_t count = len;
|
size_t count = len;
|
||||||
ssize_t ret;
|
ssize_t ret = 0;
|
||||||
|
|
||||||
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
|
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
@ -391,9 +391,20 @@ static ssize_t ifalias_store(struct device *dev, struct device_attribute *attr,
|
||||||
if (len > 0 && buf[len - 1] == '\n')
|
if (len > 0 && buf[len - 1] == '\n')
|
||||||
--count;
|
--count;
|
||||||
|
|
||||||
ret = dev_set_alias(netdev, buf, count);
|
if (!rtnl_trylock())
|
||||||
|
return restart_syscall();
|
||||||
|
|
||||||
return ret < 0 ? ret : len;
|
if (dev_isalive(netdev)) {
|
||||||
|
ret = dev_set_alias(netdev, buf, count);
|
||||||
|
if (ret < 0)
|
||||||
|
goto err;
|
||||||
|
ret = len;
|
||||||
|
netdev_state_change(netdev);
|
||||||
|
}
|
||||||
|
err:
|
||||||
|
rtnl_unlock();
|
||||||
|
|
||||||
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static ssize_t ifalias_show(struct device *dev,
|
static ssize_t ifalias_show(struct device *dev,
|
||||||
|
|
Loading…
Reference in New Issue