hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ARM: EXYNOS: Handle of_find_device_by_node() and kstrdup() failures 

Prevent possible NULL pointer dereference of pointer returned by
of_find_device_by_node(). Handle this by skipping such power domain.

Additionally fail the init on kstrdup() failure. Such case is actually
not fatal because the name for power domain allocated by kstrdup() is
used only in printk. Still as a precaution handle this as an error
condition.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Kukjin Kim <kgene@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2015-03-27 13:12:00 +01:00 committed by Kukjin Kim
parent ef2156cf4b
commit c88cad34d4
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/arm/mach-exynos/pm_domains.c
View File

@ -126,6 +126,12 @@ static __init int exynos4_pm_init_power_domain(void)
struct device *dev;
pdev = of_find_device_by_node(np);
if (!pdev) {
pr_err("%s: failed to find device for node %s\n",
__func__, np->name);
of_node_put(np);
continue;
}
dev = &pdev->dev;
pd = kzalloc(sizeof(*pd), GFP_KERNEL);
@ -136,6 +142,12 @@ static __init int exynos4_pm_init_power_domain(void)
}
pd->pd.name = kstrdup(dev_name(dev), GFP_KERNEL);
if (!pd->pd.name) {
kfree(pd);
of_node_put(np);
return -ENOMEM;
}
pd->name = pd->pd.name;
pd->base = of_iomap(np, 0);
if (!pd->base) {