hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf report: Remove unnecessary check in annotate_browser_write() 

In annotate_browser_write(),

        if (dl->offset != -1 && percent_max != 0.0) {
                if (percent_max != 0.0) {
			...
                }
                ...
        }

The second check of (percent_max != 0.0) is not necessary, remove it.

Signed-off-by: Yao Jin <yao.jin@linux.intel.com>
Acked-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yao Jin <yao.jin@linux.intel.com>
Link: http://lkml.kernel.org/r/1493909895-9668-2-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jin Yao 2017-05-04 22:58:14 +08:00 committed by Arnaldo Carvalho de Melo
parent 8052bd8243
commit c564f0db92
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tools/perf/ui/browsers/annotate.c
View File

@ -132,21 +132,17 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
} }
if (dl->offset != -1 && percent_max != 0.0) { if (dl->offset != -1 && percent_max != 0.0) {
if (percent_max != 0.0) { for (i = 0; i < ab->nr_events; i++) {
for (i = 0; i < ab->nr_events; i++) { ui_browser__set_percent_color(browser,
ui_browser__set_percent_color(browser, bdl->samples[i].percent,
bdl->samples[i].percent, current_entry);
current_entry); if (annotate_browser__opts.show_total_period) {
if (annotate_browser__opts.show_total_period) { ui_browser__printf(browser, "%6" PRIu64 " ",
ui_browser__printf(browser, "%6" PRIu64 " ", bdl->samples[i].nr);
bdl->samples[i].nr); } else {
} else { ui_browser__printf(browser, "%6.2f ",
ui_browser__printf(browser, "%6.2f ", bdl->samples[i].percent);
bdl->samples[i].percent);
}
} }
} else {
ui_browser__write_nstring(browser, " ", 7 * ab->nr_events);
} }
} else { } else {
ui_browser__set_percent_color(browser, 0, current_entry); ui_browser__set_percent_color(browser, 0, current_entry);