hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: line6: add bounds check in snd_toneport_source_put() 

"source" comes from the user in snd_ctl_elem_write() so it needs to be
checked.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2013-09-13 11:07:13 +03:00 committed by Greg Kroah-Hartman
parent 650433b8b1
commit c3cb718acc
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/line6/toneport.c
View File

@ -244,13 +244,17 @@ static int snd_toneport_source_put(struct snd_kcontrol *kcontrol,
struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol); struct snd_line6_pcm *line6pcm = snd_kcontrol_chip(kcontrol);
struct usb_line6_toneport *toneport = struct usb_line6_toneport *toneport =
(struct usb_line6_toneport *)line6pcm->line6; (struct usb_line6_toneport *)line6pcm->line6;
unsigned int source;
if (ucontrol->value.enumerated.item[0] == toneport->source) source = ucontrol->value.enumerated.item[0];
if (source >= ARRAY_SIZE(toneport_source_info))
return -EINVAL;
if (source == toneport->source)
return 0; return 0;
toneport->source = ucontrol->value.enumerated.item[0]; toneport->source = source;
toneport_send_cmd(toneport->line6.usbdev, toneport_send_cmd(toneport->line6.usbdev,
toneport_source_info[toneport->source].code, 0x0000); toneport_source_info[source].code, 0x0000);
return 1; return 1;
} }