bonding: remove the redundant judgements for bond_option_queue_id_set()
The dev_valid_name() will check the buffer length for input name, no need to check it twice. Cc: Jay Vosburgh <fubar@us.ibm.com> Cc: Veaceslav Falico <vfalico@redhat.com> Cc: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Reviewed-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
805d157e8f
commit
c313c89edb
|
@ -1199,8 +1199,7 @@ int bond_option_queue_id_set(struct bonding *bond,
|
|||
goto err_no_cmd;
|
||||
|
||||
/* Check buffer length, valid ifname and queue id */
|
||||
if (strlen(newval->string) > IFNAMSIZ ||
|
||||
!dev_valid_name(newval->string) ||
|
||||
if (!dev_valid_name(newval->string) ||
|
||||
qid > bond->dev->real_num_tx_queues)
|
||||
goto err_no_cmd;
|
||||
|
||||
|
|
Loading…
Reference in New Issue