hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mac80211: simplify zero address checks 

The libertas_tf special code for zero addresses
is a bit too complex, it compares against a stack
value instead of using is_zero_ether_addr() and
tries to update all interfaces even if just the
one that's being brought up needs to be changed.
Additionally, the repeated check for a valid MAC
address need only be done if we actually changed
it on the fly.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Johannes Berg 2010-08-27 12:35:56 +02:00 committed by John W. Linville
parent 26a58456be
commit bf533e0bfd
1 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
net/mac80211/iface.c
View File

@ -103,10 +103,9 @@ static int ieee80211_open(struct net_device *dev)
u32 changed = 0; u32 changed = 0;
int res; int res;
u32 hw_reconf_flags = 0; u32 hw_reconf_flags = 0;
u8 null_addr[ETH_ALEN] = {0};
/* fail early if user set an invalid address */ /* fail early if user set an invalid address */
if (compare_ether_addr(dev->dev_addr, null_addr) && if (!is_zero_ether_addr(dev->dev_addr) &&
!is_valid_ether_addr(dev->dev_addr)) !is_valid_ether_addr(dev->dev_addr))
return -EADDRNOTAVAIL; return -EADDRNOTAVAIL;
@ -195,33 +194,22 @@ static int ieee80211_open(struct net_device *dev)
} }
/* /*
* Check all interfaces and copy the hopefully now-present * Copy the hopefully now-present MAC address to
* MAC address to those that have the special null one. * this interface, if it has the special null one.
*/ */
list_for_each_entry(nsdata, &local->interfaces, list) { if (is_zero_ether_addr(dev->dev_addr)) {
struct net_device *ndev = nsdata->dev; memcpy(dev->dev_addr,
local->hw.wiphy->perm_addr,
ETH_ALEN);
memcpy(dev->perm_addr, dev->dev_addr, ETH_ALEN);
/* if (!is_valid_ether_addr(dev->dev_addr)) {
* No need to check running since we do not allow if (!local->open_count)
* it to start up with this invalid address. drv_stop(local);
*/ return -EADDRNOTAVAIL;
if (compare_ether_addr(null_addr, ndev->dev_addr) == 0) {
memcpy(ndev->dev_addr,
local->hw.wiphy->perm_addr,
ETH_ALEN);
memcpy(ndev->perm_addr, ndev->dev_addr, ETH_ALEN);
} }
} }
/*
* Validate the MAC address for this device.
*/
if (!is_valid_ether_addr(dev->dev_addr)) {
if (!local->open_count)
drv_stop(local);
return -EADDRNOTAVAIL;
}
switch (sdata->vif.type) { switch (sdata->vif.type) {
case NL80211_IFTYPE_AP_VLAN: case NL80211_IFTYPE_AP_VLAN:
/* no need to tell driver */ /* no need to tell driver */