hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: netcp: add missing of_node_put 

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression r.n;
expression r,e;
@@

 for_each_child_of_node(r,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall 2015-10-25 14:57:01 +01:00 committed by David S. Miller
parent 8c387ebbaf
commit bd25279685
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/ti/netcp_ethss.c
View File

@ -2637,9 +2637,11 @@ static void init_secondary_ports(struct gbe_priv *gbe_dev,
mac_phy_link = true; mac_phy_link = true;
slave->open = true; slave->open = true;
if (gbe_dev->num_slaves >= gbe_dev->max_num_slaves) if (gbe_dev->num_slaves >= gbe_dev->max_num_slaves) {
of_node_put(port);
break; break;
} }
}
/* of_phy_connect() is needed only for MAC-PHY interface */ /* of_phy_connect() is needed only for MAC-PHY interface */
if (!mac_phy_link) if (!mac_phy_link)
@ -3137,9 +3139,11 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev,
continue; continue;
} }
gbe_dev->num_slaves++; gbe_dev->num_slaves++;
if (gbe_dev->num_slaves >= gbe_dev->max_num_slaves) if (gbe_dev->num_slaves >= gbe_dev->max_num_slaves) {
of_node_put(interface);
break; break;
} }
}
of_node_put(interfaces); of_node_put(interfaces);
if (!gbe_dev->num_slaves) if (!gbe_dev->num_slaves)