media: venus: fix loop wrap in cleanup of clks
The current pre-decrement is incorrect and should be replaced with a post-decrement. Consider the case where the very first clk_prepare_enable fails when i is 0; in this case the error clean up will decrement the unsigned int which wraps to the largest unsigned int value causing an array out of bounds read on core->clks[i]. Detected by CoverityScan, CID#1446590 ("Out-of-bounds read") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Hans Verkuil <hansverk@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
13c2bede49
commit
bc8e2d627a
|
@ -137,7 +137,7 @@ static int venus_clks_enable(struct venus_core *core)
|
|||
|
||||
return 0;
|
||||
err:
|
||||
while (--i)
|
||||
while (i--)
|
||||
clk_disable_unprepare(core->clks[i]);
|
||||
|
||||
return ret;
|
||||
|
|
Loading…
Reference in New Issue