hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spi: bcm2835: remove use of uninitialized gpio flags variable 

Removing the duplicate gpio chip select level handling in
bcm2835_spi_setup() left the lflags variable uninitialized. Avoid trhe
use of such variable by passing default flags to
gpiochip_request_own_desc().

Fixes: 5e31ba0c05 ("spi: bcm2835: fix gpio cs level inversion")
Signed-off-by: Martin Hundebøll <martin@geanix.com>
Link: https://lore.kernel.org/r/20201105090615.620315-1-martin@geanix.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Martin Hundebøll 2020-11-05 10:06:15 +01:00 committed by Mark Brown
parent 9bd77a9ce3
commit bc7f2cd755
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/spi/spi-bcm2835.c
View File

@ -1193,7 +1193,6 @@ static int bcm2835_spi_setup(struct spi_device *spi)
struct spi_controller *ctlr = spi->controller; struct spi_controller *ctlr = spi->controller;
struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr); struct bcm2835_spi *bs = spi_controller_get_devdata(ctlr);
struct gpio_chip *chip; struct gpio_chip *chip;
enum gpio_lookup_flags lflags;
u32 cs; u32 cs;
/* /*
@ -1261,7 +1260,7 @@ static int bcm2835_spi_setup(struct spi_device *spi)
spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select, spi->cs_gpiod = gpiochip_request_own_desc(chip, 8 - spi->chip_select,
DRV_NAME, DRV_NAME,
lflags, GPIO_LOOKUP_FLAGS_DEFAULT,
GPIOD_OUT_LOW); GPIOD_OUT_LOW);
if (IS_ERR(spi->cs_gpiod)) if (IS_ERR(spi->cs_gpiod))
return PTR_ERR(spi->cs_gpiod); return PTR_ERR(spi->cs_gpiod);