proc: Update proc_flush_task_mnt to use d_invalidate
Now that d_invalidate always succeeds and flushes mount points use it in stead of a combination of shrink_dcache_parent and d_drop in proc_flush_task_mnt. This removes the danger of a mount point under /proc/<pid>/... becoming unreachable after the d_drop. Reviewed-by: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
c143c2333c
commit
bbd5192412
|
@ -2639,8 +2639,7 @@ static void proc_flush_task_mnt(struct vfsmount *mnt, pid_t pid, pid_t tgid)
|
||||||
/* no ->d_hash() rejects on procfs */
|
/* no ->d_hash() rejects on procfs */
|
||||||
dentry = d_hash_and_lookup(mnt->mnt_root, &name);
|
dentry = d_hash_and_lookup(mnt->mnt_root, &name);
|
||||||
if (dentry) {
|
if (dentry) {
|
||||||
shrink_dcache_parent(dentry);
|
d_invalidate(dentry);
|
||||||
d_drop(dentry);
|
|
||||||
dput(dentry);
|
dput(dentry);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2660,8 +2659,7 @@ static void proc_flush_task_mnt(struct vfsmount *mnt, pid_t pid, pid_t tgid)
|
||||||
name.len = snprintf(buf, sizeof(buf), "%d", pid);
|
name.len = snprintf(buf, sizeof(buf), "%d", pid);
|
||||||
dentry = d_hash_and_lookup(dir, &name);
|
dentry = d_hash_and_lookup(dir, &name);
|
||||||
if (dentry) {
|
if (dentry) {
|
||||||
shrink_dcache_parent(dentry);
|
d_invalidate(dentry);
|
||||||
d_drop(dentry);
|
|
||||||
dput(dentry);
|
dput(dentry);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue