hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwrng: omap3-rom - Use devm hwrng and runtime PM 

This allows us to simplify things more for probe and exit.

Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Adam Ford <aford173@gmail.com>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>
Suggested-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Tony Lindgren 2019-09-14 14:03:00 -07:00 committed by Herbert Xu
parent 8d9d4bdc49
commit bac5c49ec2
1 changed files with 16 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
drivers/char/hw_random/omap3-rom-rng.c
View File

@ -100,6 +100,14 @@ static int omap_rom_rng_runtime_resume(struct device *dev)
return 0;
}
static void omap_rom_rng_finish(void *data)
{
struct omap_rom_rng *ddata = data;
pm_runtime_dont_use_autosuspend(ddata->dev);
pm_runtime_disable(ddata->dev);
}
static int omap3_rom_rng_probe(struct platform_device *pdev)
{
struct omap_rom_rng *ddata;
@ -133,33 +141,16 @@ static int omap3_rom_rng_probe(struct platform_device *pdev)
return PTR_ERR(ddata->clk);
}
pm_runtime_enable(ddata->dev);
pm_runtime_enable(&pdev->dev);
pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
pm_runtime_use_autosuspend(&pdev->dev);
ret = hwrng_register(&ddata->ops);
if (!ret)
goto err_disable;
ret = devm_add_action_or_reset(ddata->dev, omap_rom_rng_finish,
ddata);
if (ret)
return ret;
pm_runtime_set_autosuspend_delay(ddata->dev, 500);
pm_runtime_use_autosuspend(ddata->dev);
return 0;
err_disable:
pm_runtime_disable(ddata->dev);
return ret;
}
static int omap3_rom_rng_remove(struct platform_device *pdev)
{
struct omap_rom_rng *ddata;
ddata = dev_get_drvdata(&pdev->dev);
hwrng_unregister(&ddata->ops);
pm_runtime_dont_use_autosuspend(ddata->dev);
pm_runtime_disable(ddata->dev);
return 0;
return devm_hwrng_register(ddata->dev, &ddata->ops);
}
static const struct of_device_id omap_rom_rng_match[] = {
@ -180,7 +171,6 @@ static struct platform_driver omap3_rom_rng_driver = {
.pm = &omap_rom_rng_pm_ops,
},
.probe = omap3_rom_rng_probe,
.remove = omap3_rom_rng_remove,
};
module_platform_driver(omap3_rom_rng_driver);