[PATCH] USB: Let usbmon collect less garbage
Alan Stern pointed out that (in 2.6 kernel) one successful submission results in one callback, even for ISO-out transfers. Thus, the silly check can be removed from usbmon. This reduces the amount of garbage printed in case of ISO and Interrupt transfers. Signed-off-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
687f5f3428
commit
b9b0942257
|
@ -97,12 +97,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
|
|||
if (len >= DATA_MAX)
|
||||
len = DATA_MAX;
|
||||
|
||||
/*
|
||||
* Bulk is easy to shortcut reliably.
|
||||
* XXX Other pipe types need consideration. Currently, we overdo it
|
||||
* and collect garbage for them: better more than less.
|
||||
*/
|
||||
if (usb_pipebulk(pipe) || usb_pipecontrol(pipe)) {
|
||||
if (usb_pipein(pipe)) {
|
||||
if (ev_type == 'S')
|
||||
return '<';
|
||||
|
@ -110,7 +104,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
|
|||
if (ev_type == 'C')
|
||||
return '>';
|
||||
}
|
||||
}
|
||||
|
||||
/*
|
||||
* The check to see if it's safe to poke at data has an enormous
|
||||
|
|
Loading…
Reference in New Issue