[PATCH] USB: Let usbmon collect less garbage
Alan Stern pointed out that (in 2.6 kernel) one successful submission results in one callback, even for ISO-out transfers. Thus, the silly check can be removed from usbmon. This reduces the amount of garbage printed in case of ISO and Interrupt transfers. Signed-off-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
687f5f3428
commit
b9b0942257
|
@ -97,19 +97,12 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
|
||||||
if (len >= DATA_MAX)
|
if (len >= DATA_MAX)
|
||||||
len = DATA_MAX;
|
len = DATA_MAX;
|
||||||
|
|
||||||
/*
|
if (usb_pipein(pipe)) {
|
||||||
* Bulk is easy to shortcut reliably.
|
if (ev_type == 'S')
|
||||||
* XXX Other pipe types need consideration. Currently, we overdo it
|
return '<';
|
||||||
* and collect garbage for them: better more than less.
|
} else {
|
||||||
*/
|
if (ev_type == 'C')
|
||||||
if (usb_pipebulk(pipe) || usb_pipecontrol(pipe)) {
|
return '>';
|
||||||
if (usb_pipein(pipe)) {
|
|
||||||
if (ev_type == 'S')
|
|
||||||
return '<';
|
|
||||||
} else {
|
|
||||||
if (ev_type == 'C')
|
|
||||||
return '>';
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
Loading…
Reference in New Issue