hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

leds: bcm6328: Swap LED ON and OFF definitions 

The values of BCM6328_LED_MODE_ON and BCM6328_LED_MODE_OFF were named
for active low LEDs. These should be swapped so that they are named for
the default case of active high LEDs.

Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
Simon Arlott 2015-11-15 13:34:37 +00:00 committed by Jacek Anaszewski
parent 9d3c0663df
commit b964c5ba6d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/leds/leds-bcm6328.c
View File

@ -48,10 +48,10 @@
BCM6328_SERIAL_LED_SHIFT_DIR) BCM6328_SERIAL_LED_SHIFT_DIR)
#define BCM6328_LED_MODE_MASK 3 #define BCM6328_LED_MODE_MASK 3
#define BCM6328_LED_MODE_OFF 0 #define BCM6328_LED_MODE_ON 0
#define BCM6328_LED_MODE_FAST 1 #define BCM6328_LED_MODE_FAST 1
#define BCM6328_LED_MODE_BLINK 2 #define BCM6328_LED_MODE_BLINK 2
#define BCM6328_LED_MODE_ON 3 #define BCM6328_LED_MODE_OFF 3
#define BCM6328_LED_SHIFT(X) ((X) << 1) #define BCM6328_LED_SHIFT(X) ((X) << 1)
/** /**
@ -126,9 +126,9 @@ static void bcm6328_led_set(struct led_classdev *led_cdev,
*(led->blink_leds) &= ~BIT(led->pin); *(led->blink_leds) &= ~BIT(led->pin);
if ((led->active_low && value == LED_OFF) || if ((led->active_low && value == LED_OFF) ||
(!led->active_low && value != LED_OFF)) (!led->active_low && value != LED_OFF))
bcm6328_led_mode(led, BCM6328_LED_MODE_OFF);
else
bcm6328_led_mode(led, BCM6328_LED_MODE_ON); bcm6328_led_mode(led, BCM6328_LED_MODE_ON);
else
bcm6328_led_mode(led, BCM6328_LED_MODE_OFF);
spin_unlock_irqrestore(led->lock, flags); spin_unlock_irqrestore(led->lock, flags);
} }
@ -303,8 +303,8 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
val = bcm6328_led_read(mode) >> val = bcm6328_led_read(mode) >>
BCM6328_LED_SHIFT(shift % 16); BCM6328_LED_SHIFT(shift % 16);
val &= BCM6328_LED_MODE_MASK; val &= BCM6328_LED_MODE_MASK;
if ((led->active_low && val == BCM6328_LED_MODE_ON) || if ((led->active_low && val == BCM6328_LED_MODE_OFF) ||
(!led->active_low && val == BCM6328_LED_MODE_OFF)) (!led->active_low && val == BCM6328_LED_MODE_ON))
led->cdev.brightness = LED_FULL; led->cdev.brightness = LED_FULL;
else else
led->cdev.brightness = LED_OFF; led->cdev.brightness = LED_OFF;