hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] rc/nuvoton_cir: fix locking issue when calling nvt_enable_wake 

nvt_enable_wake calls nvt_select_logical_dev (that may sleep) and is called
from contexts holding a spinlock. Fix this.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Heiner Kallweit 2016-02-01 18:50:26 -02:00 committed by Mauro Carvalho Chehab
parent 842096fc40
commit b883af30bc
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/media/rc/nuvoton-cir.c
View File

@ -503,6 +503,8 @@ static void nvt_cir_wake_regs_init(struct nvt_dev *nvt)
static void nvt_enable_wake(struct nvt_dev *nvt) static void nvt_enable_wake(struct nvt_dev *nvt)
{ {
unsigned long flags;
nvt_efm_enable(nvt); nvt_efm_enable(nvt);
nvt_select_logical_dev(nvt, LOGICAL_DEV_ACPI); nvt_select_logical_dev(nvt, LOGICAL_DEV_ACPI);
@ -514,12 +516,16 @@ static void nvt_enable_wake(struct nvt_dev *nvt)
nvt_efm_disable(nvt); nvt_efm_disable(nvt);
spin_lock_irqsave(&nvt->nvt_lock, flags);
nvt_cir_wake_reg_write(nvt, CIR_WAKE_IRCON_MODE0 | CIR_WAKE_IRCON_RXEN | nvt_cir_wake_reg_write(nvt, CIR_WAKE_IRCON_MODE0 | CIR_WAKE_IRCON_RXEN |
CIR_WAKE_IRCON_R | CIR_WAKE_IRCON_RXINV | CIR_WAKE_IRCON_R | CIR_WAKE_IRCON_RXINV |
CIR_WAKE_IRCON_SAMPLE_PERIOD_SEL, CIR_WAKE_IRCON_SAMPLE_PERIOD_SEL,
CIR_WAKE_IRCON); CIR_WAKE_IRCON);
nvt_cir_wake_reg_write(nvt, 0xff, CIR_WAKE_IRSTS); nvt_cir_wake_reg_write(nvt, 0xff, CIR_WAKE_IRSTS);
nvt_cir_wake_reg_write(nvt, 0, CIR_WAKE_IREN); nvt_cir_wake_reg_write(nvt, 0, CIR_WAKE_IREN);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
} }
#if 0 /* Currently unused */ #if 0 /* Currently unused */
@ -1152,9 +1158,10 @@ static void nvt_remove(struct pnp_dev *pdev)
/* disable CIR */ /* disable CIR */
nvt_cir_reg_write(nvt, 0, CIR_IREN); nvt_cir_reg_write(nvt, 0, CIR_IREN);
nvt_disable_cir(nvt); nvt_disable_cir(nvt);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
/* enable CIR Wake (for IR power-on) */ /* enable CIR Wake (for IR power-on) */
nvt_enable_wake(nvt); nvt_enable_wake(nvt);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
rc_unregister_device(nvt->rdev); rc_unregister_device(nvt->rdev);
} }
@ -1179,14 +1186,14 @@ static int nvt_suspend(struct pnp_dev *pdev, pm_message_t state)
/* disable all CIR interrupts */ /* disable all CIR interrupts */
nvt_cir_reg_write(nvt, 0, CIR_IREN); nvt_cir_reg_write(nvt, 0, CIR_IREN);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
/* disable cir logical dev */ /* disable cir logical dev */
nvt_disable_logical_dev(nvt, LOGICAL_DEV_CIR); nvt_disable_logical_dev(nvt, LOGICAL_DEV_CIR);
/* make sure wake is enabled */ /* make sure wake is enabled */
nvt_enable_wake(nvt); nvt_enable_wake(nvt);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
return 0; return 0;
} }
@ -1205,11 +1212,8 @@ static int nvt_resume(struct pnp_dev *pdev)
static void nvt_shutdown(struct pnp_dev *pdev) static void nvt_shutdown(struct pnp_dev *pdev)
{ {
struct nvt_dev *nvt = pnp_get_drvdata(pdev); struct nvt_dev *nvt = pnp_get_drvdata(pdev);
unsigned long flags;
spin_lock_irqsave(&nvt->nvt_lock, flags);
nvt_enable_wake(nvt); nvt_enable_wake(nvt);
spin_unlock_irqrestore(&nvt->nvt_lock, flags);
} }
static const struct pnp_device_id nvt_ids[] = { static const struct pnp_device_id nvt_ids[] = {