hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: phy: micrel: refactor led-mode error handling 

Refactor led-mode error handling.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Johan Hovold 2014-11-11 20:00:13 +01:00 committed by David S. Miller
parent 8620546c39
commit b7035860a1
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/net/phy/micrel.c
View File

@ -179,14 +179,19 @@ static int kszphy_setup_led(struct phy_device *phydev,
} }
temp = phy_read(phydev, reg); temp = phy_read(phydev, reg);
if (temp < 0) if (temp < 0) {
return temp; rc = temp;
goto out;
}
temp &= ~(3 << shift); temp &= ~(3 << shift);
temp |= val << shift; temp |= val << shift;
rc = phy_write(phydev, reg, temp); rc = phy_write(phydev, reg, temp);
out:
if (rc < 0)
dev_err(&phydev->dev, "failed to set led mode\n");
return rc < 0 ? rc : 0; return rc;
} }
/* Disable PHY address 0 as the broadcast address, so that it can be used as a /* Disable PHY address 0 as the broadcast address, so that it can be used as a
@ -223,9 +228,7 @@ static int ksz8021_config_init(struct phy_device *phydev)
{ {
int rc; int rc;
rc = kszphy_setup_led(phydev, 0x1f, 4); kszphy_setup_led(phydev, 0x1f, 4);
if (rc)
dev_err(&phydev->dev, "failed to set led mode\n");
rc = ksz_config_flags(phydev); rc = ksz_config_flags(phydev);
if (rc < 0) if (rc < 0)
@ -240,9 +243,7 @@ static int ks8051_config_init(struct phy_device *phydev)
{ {
int rc; int rc;
rc = kszphy_setup_led(phydev, 0x1f, 4); kszphy_setup_led(phydev, 0x1f, 4);
if (rc)
dev_err(&phydev->dev, "failed to set led mode\n");
rc = ksz_config_flags(phydev); rc = ksz_config_flags(phydev);
return rc < 0 ? rc : 0; return rc < 0 ? rc : 0;