fuse: get page reference for readpages
Acquire a page ref on pages in ->readpages() and release them when the read has finished. Not acquiring a reference didn't seem to cause any trouble since the page is locked and will not be kicked out of the page cache during the read. However the following patches will want to remove the page from the cache so a separate ref is needed. Making the reference in req->pages explicit also makes the code easier to understand. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
This commit is contained in:
parent
1bf94ca73e
commit
b5dd328537
|
@ -536,6 +536,7 @@ static void fuse_readpages_end(struct fuse_conn *fc, struct fuse_req *req)
|
|||
else
|
||||
SetPageError(page);
|
||||
unlock_page(page);
|
||||
page_cache_release(page);
|
||||
}
|
||||
if (req->ff)
|
||||
fuse_file_put(req->ff);
|
||||
|
@ -589,6 +590,7 @@ static int fuse_readpages_fill(void *_data, struct page *page)
|
|||
return PTR_ERR(req);
|
||||
}
|
||||
}
|
||||
page_cache_get(page);
|
||||
req->pages[req->num_pages] = page;
|
||||
req->num_pages++;
|
||||
return 0;
|
||||
|
|
Loading…
Reference in New Issue