sfc: Log specific message for failure of NVRAM self-test

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ben Hutchings 2010-04-28 09:28:36 +00:00 committed by David S. Miller
parent 41b7e4c326
commit b548a988a9
1 changed files with 8 additions and 2 deletions

View File

@ -932,20 +932,26 @@ int efx_mcdi_nvram_test_all(struct efx_nic *efx)
rc = efx_mcdi_nvram_types(efx, &nvram_types); rc = efx_mcdi_nvram_types(efx, &nvram_types);
if (rc) if (rc)
return rc; goto fail1;
type = 0; type = 0;
while (nvram_types != 0) { while (nvram_types != 0) {
if (nvram_types & 1) { if (nvram_types & 1) {
rc = efx_mcdi_nvram_test(efx, type); rc = efx_mcdi_nvram_test(efx, type);
if (rc) if (rc)
return rc; goto fail2;
} }
type++; type++;
nvram_types >>= 1; nvram_types >>= 1;
} }
return 0; return 0;
fail2:
EFX_ERR(efx, "%s: failed type=%u\n", __func__, type);
fail1:
EFX_ERR(efx, "%s: failed rc=%d\n", __func__, rc);
return rc;
} }
static int efx_mcdi_read_assertion(struct efx_nic *efx) static int efx_mcdi_read_assertion(struct efx_nic *efx)