hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe() 

In case of error, the function devm_ioremap() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 2ff8a1eeb5 ("phy: Add Sparx5 ethernet serdes PHY driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210909072149.2934047-1-yangyingliang@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Yang Yingliang 2021-09-09 15:21:49 +08:00 committed by Vinod Koul
parent b475bf0ec4
commit b4dc97ab0a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/phy/microchip/sparx5_serdes.c
View File

@ -2475,10 +2475,10 @@ static int sparx5_serdes_probe(struct platform_device *pdev)
return -EINVAL; return -EINVAL;
} }
iomem = devm_ioremap(priv->dev, iores->start, resource_size(iores)); iomem = devm_ioremap(priv->dev, iores->start, resource_size(iores));
if (IS_ERR(iomem)) { if (!iomem) {
dev_err(priv->dev, "Unable to get serdes registers: %s\n", dev_err(priv->dev, "Unable to get serdes registers: %s\n",
iores->name); iores->name);
return PTR_ERR(iomem); return -ENOMEM;
} }
for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) { for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) {
struct sparx5_serdes_io_resource *iomap = &sparx5_serdes_iomap[idx]; struct sparx5_serdes_io_resource *iomap = &sparx5_serdes_iomap[idx];