hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

greybus: core: add device prefix to error messages 

Use dev_err and dev_warn where appropriate and remove now unused pr_fmt
defines.

Testing Done:
Tested on DB3.5 with the generic bridge firmware on APB2.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2016-02-11 13:52:47 +01:00 committed by Greg Kroah-Hartman
parent a0b5542df2
commit b427572ebf
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/greybus/debugfs.c
View File

@ -7,8 +7,6 @@
* Released under the GPLv2 only. * Released under the GPLv2 only.
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/debugfs.h> #include <linux/debugfs.h>
#include "greybus.h" #include "greybus.h"

4
drivers/staging/greybus/hd.c
View File

@ -7,8 +7,6 @@
* Released under the GPLv2 only. * Released under the GPLv2 only.
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/slab.h> #include <linux/slab.h>
@ -55,7 +53,7 @@ struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver,
* so that we don't have to every time we make them. * so that we don't have to every time we make them.
*/ */
if ((!driver->message_send) || (!driver->message_cancel)) { if ((!driver->message_send) || (!driver->message_cancel)) {
pr_err("Must implement all gb_hd_driver callbacks!\n"); dev_err(parent, "mandatory hd-callbacks missing\n");
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
} }

2
drivers/staging/greybus/operation.c
View File

@ -327,7 +327,7 @@ gb_operation_message_alloc(struct gb_host_device *hd, u8 type,
size_t message_size = payload_size + sizeof(*header); size_t message_size = payload_size + sizeof(*header);
if (message_size > hd->buffer_size_max) { if (message_size > hd->buffer_size_max) {
pr_warn("requested message size too big (%zu > %zu)\n", dev_warn(&hd->dev, "requested message size too big (%zu > %zu)\n",
message_size, hd->buffer_size_max); message_size, hd->buffer_size_max);
return NULL; return NULL;
} }