hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

isdn/gigaset: bas_gigaset locking fix 

Unlock cs->lock before calling error_hangup() which is marked
"cs->lock must not be held".

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
CC: stable <stable@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tilman Schmidt 2010-09-30 13:34:30 +00:00 committed by David S. Miller
parent c7ebfdaca0
commit b33ffa5cbf
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/isdn/gigaset/bas-gigaset.c
View File

@ -1598,13 +1598,13 @@ static int gigaset_init_bchannel(struct bc_state *bcs)
ret = starturbs(bcs); ret = starturbs(bcs);
if (ret < 0) { if (ret < 0) {
spin_unlock_irqrestore(&cs->lock, flags);
dev_err(cs->dev, dev_err(cs->dev,
"could not start isochronous I/O for channel B%d: %s\n", "could not start isochronous I/O for channel B%d: %s\n",
bcs->channel + 1, bcs->channel + 1,
ret == -EFAULT ? "null URB" : get_usb_rcmsg(ret)); ret == -EFAULT ? "null URB" : get_usb_rcmsg(ret));
if (ret != -ENODEV) if (ret != -ENODEV)
error_hangup(bcs); error_hangup(bcs);
spin_unlock_irqrestore(&cs->lock, flags);
return ret; return ret;
} }
@ -1614,11 +1614,11 @@ static int gigaset_init_bchannel(struct bc_state *bcs)
dev_err(cs->dev, "could not open channel B%d\n", dev_err(cs->dev, "could not open channel B%d\n",
bcs->channel + 1); bcs->channel + 1);
stopurbs(bcs->hw.bas); stopurbs(bcs->hw.bas);
if (ret != -ENODEV)
error_hangup(bcs);
} }
spin_unlock_irqrestore(&cs->lock, flags); spin_unlock_irqrestore(&cs->lock, flags);
if (ret < 0 && ret != -ENODEV)
error_hangup(bcs);
return ret; return ret;
} }