cxl: Destroy cxl_adapter_idr on module_exit

Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory.

This was detected by the following semantic patch (written by Luis Rodriguez
<mcgrof@suse.com>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@

module_init(init);

@ defines_module_exit @
identifier exit;
@@

module_exit(exit);

@ declares_idr depends on defines_module_init && defines_module_exit @
identifier idr;
@@

DEFINE_IDR(idr);

@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 idr_destroy(&idr);
 ...
}

@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 +idr_destroy(&idr);
}
</SmPL>

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

This commit is contained in:

Johannes Thumshirn

2015-07-08 17:14:36 +02:00

committed by

Michael Ellerman

parent 3b476aadbc

commit b2a02ac65e

1 changed files with 1 additions and 0 deletions

									
										1

drivers/misc/cxl/main.c

										View File
									
				@ -222,6 +222,7 @@ static void exit_cxl(void)

					cxl_debugfs_exit();

					cxl_file_exit();

					unregister_cxl_calls(&cxl_calls);

					idr_destroy(&cxl_adapter_idr);

				}

				module_init(init_cxl);

cxl: Destroy cxl_adapter_idr on module_exit

1 drivers/misc/cxl/main.c Unescape Escape View File

1

drivers/misc/cxl/main.c

View File