hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[PATCH] cpuset: memory_spread_slab drop useless PF_SPREAD_PAGE check 

The hook in the slab cache allocation path to handle cpuset memory
spreading for tasks in cpusets with 'memory_spread_slab' enabled has a
modest performance bug.  The hook calls into the memory spreading handler
alternate_node_alloc() if either of 'memory_spread_slab' or
'memory_spread_page' is enabled, even though the handler does nothing
(albeit harmlessly) for the page case

Fix - drop PF_SPREAD_PAGE from the set of flag bits that are used to
trigger a call to alternate_node_alloc().

The page case is handled by separate hooks -- see the calls conditioned on
cpuset_do_page_mem_spread() in mm/filemap.c

Signed-off-by: Paul Jackson <pj@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Paul Jackson 2006-03-24 03:16:12 -08:00 committed by Linus Torvalds
parent 151a44202d
commit b2455396be
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mm/slab.c
View File

@ -2809,8 +2809,7 @@ static inline void *____cache_alloc(struct kmem_cache *cachep, gfp_t flags)
struct array_cache *ac; struct array_cache *ac;
#ifdef CONFIG_NUMA #ifdef CONFIG_NUMA
if (unlikely(current->flags & (PF_SPREAD_PAGE | PF_SPREAD_SLAB | if (unlikely(current->flags & (PF_SPREAD_SLAB | PF_MEMPOLICY))) {
PF_MEMPOLICY))) {
objp = alternate_node_alloc(cachep, flags); objp = alternate_node_alloc(cachep, flags);
if (objp != NULL) if (objp != NULL)
return objp; return objp;
@ -2849,7 +2848,7 @@ static __always_inline void *__cache_alloc(struct kmem_cache *cachep,
#ifdef CONFIG_NUMA #ifdef CONFIG_NUMA
/* /*
* Try allocating on another node if PF_SPREAD_PAGE|PF_SPREAD_SLAB|PF_MEMPOLICY. * Try allocating on another node if PF_SPREAD_SLAB|PF_MEMPOLICY.
* *
* If we are in_interrupt, then process context, including cpusets and * If we are in_interrupt, then process context, including cpusets and
* mempolicy, may not apply and should not be used for allocation policy. * mempolicy, may not apply and should not be used for allocation policy.