gpio: rcar: Add helper variable dev = &pdev->dev
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Cc: linux-gpio@vger.kernel.org Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
8650ea1ebc
commit
b22978fc33
|
@ -356,12 +356,13 @@ static int gpio_rcar_probe(struct platform_device *pdev)
|
||||||
struct resource *io, *irq;
|
struct resource *io, *irq;
|
||||||
struct gpio_chip *gpio_chip;
|
struct gpio_chip *gpio_chip;
|
||||||
struct irq_chip *irq_chip;
|
struct irq_chip *irq_chip;
|
||||||
const char *name = dev_name(&pdev->dev);
|
struct device *dev = &pdev->dev;
|
||||||
|
const char *name = dev_name(dev);
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
|
p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
|
||||||
if (!p) {
|
if (!p) {
|
||||||
dev_err(&pdev->dev, "failed to allocate driver data\n");
|
dev_err(dev, "failed to allocate driver data\n");
|
||||||
ret = -ENOMEM;
|
ret = -ENOMEM;
|
||||||
goto err0;
|
goto err0;
|
||||||
}
|
}
|
||||||
|
@ -380,15 +381,14 @@ static int gpio_rcar_probe(struct platform_device *pdev)
|
||||||
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
|
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
|
||||||
|
|
||||||
if (!io || !irq) {
|
if (!io || !irq) {
|
||||||
dev_err(&pdev->dev, "missing IRQ or IOMEM\n");
|
dev_err(dev, "missing IRQ or IOMEM\n");
|
||||||
ret = -EINVAL;
|
ret = -EINVAL;
|
||||||
goto err0;
|
goto err0;
|
||||||
}
|
}
|
||||||
|
|
||||||
p->base = devm_ioremap_nocache(&pdev->dev, io->start,
|
p->base = devm_ioremap_nocache(dev, io->start, resource_size(io));
|
||||||
resource_size(io));
|
|
||||||
if (!p->base) {
|
if (!p->base) {
|
||||||
dev_err(&pdev->dev, "failed to remap I/O memory\n");
|
dev_err(dev, "failed to remap I/O memory\n");
|
||||||
ret = -ENXIO;
|
ret = -ENXIO;
|
||||||
goto err0;
|
goto err0;
|
||||||
}
|
}
|
||||||
|
@ -402,7 +402,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
|
||||||
gpio_chip->set = gpio_rcar_set;
|
gpio_chip->set = gpio_rcar_set;
|
||||||
gpio_chip->to_irq = gpio_rcar_to_irq;
|
gpio_chip->to_irq = gpio_rcar_to_irq;
|
||||||
gpio_chip->label = name;
|
gpio_chip->label = name;
|
||||||
gpio_chip->dev = &pdev->dev;
|
gpio_chip->dev = dev;
|
||||||
gpio_chip->owner = THIS_MODULE;
|
gpio_chip->owner = THIS_MODULE;
|
||||||
gpio_chip->base = p->config.gpio_base;
|
gpio_chip->base = p->config.gpio_base;
|
||||||
gpio_chip->ngpio = p->config.number_of_pins;
|
gpio_chip->ngpio = p->config.number_of_pins;
|
||||||
|
@ -421,30 +421,30 @@ static int gpio_rcar_probe(struct platform_device *pdev)
|
||||||
&gpio_rcar_irq_domain_ops, p);
|
&gpio_rcar_irq_domain_ops, p);
|
||||||
if (!p->irq_domain) {
|
if (!p->irq_domain) {
|
||||||
ret = -ENXIO;
|
ret = -ENXIO;
|
||||||
dev_err(&pdev->dev, "cannot initialize irq domain\n");
|
dev_err(dev, "cannot initialize irq domain\n");
|
||||||
goto err0;
|
goto err0;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (devm_request_irq(&pdev->dev, irq->start,
|
if (devm_request_irq(dev, irq->start, gpio_rcar_irq_handler,
|
||||||
gpio_rcar_irq_handler, IRQF_SHARED, name, p)) {
|
IRQF_SHARED, name, p)) {
|
||||||
dev_err(&pdev->dev, "failed to request IRQ\n");
|
dev_err(dev, "failed to request IRQ\n");
|
||||||
ret = -ENOENT;
|
ret = -ENOENT;
|
||||||
goto err1;
|
goto err1;
|
||||||
}
|
}
|
||||||
|
|
||||||
ret = gpiochip_add(gpio_chip);
|
ret = gpiochip_add(gpio_chip);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
dev_err(&pdev->dev, "failed to add GPIO controller\n");
|
dev_err(dev, "failed to add GPIO controller\n");
|
||||||
goto err1;
|
goto err1;
|
||||||
}
|
}
|
||||||
|
|
||||||
dev_info(&pdev->dev, "driving %d GPIOs\n", p->config.number_of_pins);
|
dev_info(dev, "driving %d GPIOs\n", p->config.number_of_pins);
|
||||||
|
|
||||||
/* warn in case of mismatch if irq base is specified */
|
/* warn in case of mismatch if irq base is specified */
|
||||||
if (p->config.irq_base) {
|
if (p->config.irq_base) {
|
||||||
ret = irq_find_mapping(p->irq_domain, 0);
|
ret = irq_find_mapping(p->irq_domain, 0);
|
||||||
if (p->config.irq_base != ret)
|
if (p->config.irq_base != ret)
|
||||||
dev_warn(&pdev->dev, "irq base mismatch (%u/%u)\n",
|
dev_warn(dev, "irq base mismatch (%u/%u)\n",
|
||||||
p->config.irq_base, ret);
|
p->config.irq_base, ret);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -452,7 +452,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
|
||||||
ret = gpiochip_add_pin_range(gpio_chip, p->config.pctl_name, 0,
|
ret = gpiochip_add_pin_range(gpio_chip, p->config.pctl_name, 0,
|
||||||
gpio_chip->base, gpio_chip->ngpio);
|
gpio_chip->base, gpio_chip->ngpio);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
dev_warn(&pdev->dev, "failed to add pin range\n");
|
dev_warn(dev, "failed to add pin range\n");
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Loading…
Reference in New Issue