hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libata: return boolean values from ata_is_* 

This way we don't have to worry about the exact bit postition of the
test to leak out and any crazy propagation effects in the callers.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Christoph Hellwig 2016-07-14 09:05:42 +09:00 committed by Tejun Heo
parent 2983860c76
commit b1c04e80c6
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
include/linux/libata.h
View File

@ -1063,32 +1063,32 @@ static inline unsigned int ata_prot_flags(u8 prot)
return 0; return 0;
} }
static inline int ata_is_atapi(u8 prot) static inline bool ata_is_atapi(u8 prot)
{ {
return ata_prot_flags(prot) & ATA_PROT_FLAG_ATAPI; return ata_prot_flags(prot) & ATA_PROT_FLAG_ATAPI;
} }
static inline int ata_is_nodata(u8 prot) static inline bool ata_is_nodata(u8 prot)
{ {
return !(ata_prot_flags(prot) & ATA_PROT_FLAG_DATA); return !(ata_prot_flags(prot) & ATA_PROT_FLAG_DATA);
} }
static inline int ata_is_pio(u8 prot) static inline bool ata_is_pio(u8 prot)
{ {
return ata_prot_flags(prot) & ATA_PROT_FLAG_PIO; return ata_prot_flags(prot) & ATA_PROT_FLAG_PIO;
} }
static inline int ata_is_dma(u8 prot) static inline bool ata_is_dma(u8 prot)
{ {
return ata_prot_flags(prot) & ATA_PROT_FLAG_DMA; return ata_prot_flags(prot) & ATA_PROT_FLAG_DMA;
} }
static inline int ata_is_ncq(u8 prot) static inline bool ata_is_ncq(u8 prot)
{ {
return ata_prot_flags(prot) & ATA_PROT_FLAG_NCQ; return ata_prot_flags(prot) & ATA_PROT_FLAG_NCQ;
} }
static inline int ata_is_data(u8 prot) static inline bool ata_is_data(u8 prot)
{ {
return ata_prot_flags(prot) & ATA_PROT_FLAG_DATA; return ata_prot_flags(prot) & ATA_PROT_FLAG_DATA;
} }
@ -1407,7 +1407,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap)
return ap->nr_pmp_links != 0; return ap->nr_pmp_links != 0;
} }
static inline int ata_is_host_link(const struct ata_link *link) static inline bool ata_is_host_link(const struct ata_link *link)
{ {
return link == &link->ap->link || link == link->ap->slave_link; return link == &link->ap->link || link == link->ap->slave_link;
} }
@ -1422,7 +1422,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap)
return false; return false;
} }
static inline int ata_is_host_link(const struct ata_link *link) static inline bool ata_is_host_link(const struct ata_link *link)
{ {
return 1; return 1;
} }