hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bcache: fix input overflow to cache set io_error_limit 

c->error_limit is in type unsigned int, it is set via cache set sysfs
file io_error_limit. Inside the bcache code, input string is converted
by strtoul_or_return() and set the converted value to c->error_limit.

Because the converted value is unsigned long, and c->error_limit is
unsigned int, if the input is large enought, overflow will happen to
c->error_limit.

This patch uses sysfs_strtoul_clamp() to convert input string, and set
the range in [0, UINT_MAX] to avoid the potential overflow.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Coly Li 2019-02-09 12:53:09 +08:00 committed by Jens Axboe
parent 453745fbbe
commit b15008403b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/md/bcache/sysfs.c
View File

@ -801,8 +801,7 @@ STORE(__bch_cache_set)
c->on_error = v; c->on_error = v;
} }
if (attr == &sysfs_io_error_limit) sysfs_strtoul_clamp(io_error_limit, c->error_limit, 0, UINT_MAX);
c->error_limit = strtoul_or_return(buf);
/* See count_io_errors() for why 88 */ /* See count_io_errors() for why 88 */
if (attr == &sysfs_io_error_halflife) if (attr == &sysfs_io_error_halflife)