drm/nouveau/disp: sizeof() wrong pointer
"data" is a void pointer and "args" is "data" after we have casted it to a struct. We care about the size of the struct here. Btw, sizeof(*data) is 1. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
This commit is contained in:
parent
264ce192b3
commit
af1ac18a19
|
@ -333,7 +333,7 @@ nv50_disp_sync_ctor(struct nouveau_object *parent,
|
|||
struct nv50_disp_dmac *dmac;
|
||||
int ret;
|
||||
|
||||
if (size < sizeof(*data) || args->head > 1)
|
||||
if (size < sizeof(*args) || args->head > 1)
|
||||
return -EINVAL;
|
||||
|
||||
ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
|
||||
|
@ -372,7 +372,7 @@ nv50_disp_ovly_ctor(struct nouveau_object *parent,
|
|||
struct nv50_disp_dmac *dmac;
|
||||
int ret;
|
||||
|
||||
if (size < sizeof(*data) || args->head > 1)
|
||||
if (size < sizeof(*args) || args->head > 1)
|
||||
return -EINVAL;
|
||||
|
||||
ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
|
||||
|
|
|
@ -228,7 +228,7 @@ nvd0_disp_sync_ctor(struct nouveau_object *parent,
|
|||
struct nv50_disp_dmac *dmac;
|
||||
int ret;
|
||||
|
||||
if (size < sizeof(*data) || args->head >= priv->head.nr)
|
||||
if (size < sizeof(*args) || args->head >= priv->head.nr)
|
||||
return -EINVAL;
|
||||
|
||||
ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
|
||||
|
@ -268,7 +268,7 @@ nvd0_disp_ovly_ctor(struct nouveau_object *parent,
|
|||
struct nv50_disp_dmac *dmac;
|
||||
int ret;
|
||||
|
||||
if (size < sizeof(*data) || args->head >= priv->head.nr)
|
||||
if (size < sizeof(*args) || args->head >= priv->head.nr)
|
||||
return -EINVAL;
|
||||
|
||||
ret = nv50_disp_dmac_create_(parent, engine, oclass, args->pushbuf,
|
||||
|
|
Loading…
Reference in New Issue