kgdboc,kgdbts: strlen() doesn't count the terminator
This is an off by one because strlen() doesn't count the null terminator. We strcpy() these strings into an array of size MAX_CONFIG_LEN. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
This commit is contained in:
parent
521cb40b0c
commit
adb4b83c12
|
@ -988,7 +988,7 @@ static void kgdbts_run_tests(void)
|
||||||
|
|
||||||
static int kgdbts_option_setup(char *opt)
|
static int kgdbts_option_setup(char *opt)
|
||||||
{
|
{
|
||||||
if (strlen(opt) > MAX_CONFIG_LEN) {
|
if (strlen(opt) >= MAX_CONFIG_LEN) {
|
||||||
printk(KERN_ERR "kgdbts: config string too long\n");
|
printk(KERN_ERR "kgdbts: config string too long\n");
|
||||||
return -ENOSPC;
|
return -ENOSPC;
|
||||||
}
|
}
|
||||||
|
|
|
@ -131,7 +131,7 @@ static void kgdboc_unregister_kbd(void)
|
||||||
|
|
||||||
static int kgdboc_option_setup(char *opt)
|
static int kgdboc_option_setup(char *opt)
|
||||||
{
|
{
|
||||||
if (strlen(opt) > MAX_CONFIG_LEN) {
|
if (strlen(opt) >= MAX_CONFIG_LEN) {
|
||||||
printk(KERN_ERR "kgdboc: config string too long\n");
|
printk(KERN_ERR "kgdboc: config string too long\n");
|
||||||
return -ENOSPC;
|
return -ENOSPC;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue