hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kselftest/cgroup: fix variable dereferenced before check warning 

cg_name(const char *root, const char *name) is always called with
non-empty root and name arguments, so there is no sense in checking
it in the function body (after using in strlen()).

Signed-off-by: Roman Gushchin <guro@fb.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
This commit is contained in:
Roman Gushchin 2018-05-22 11:10:31 +01:00 committed by Shuah Khan (Samsung OSG)
parent 7b04d1e9c6
commit adb31be442
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testing/selftests/cgroup/cgroup_util.c
View File

@ -59,8 +59,7 @@ char *cg_name(const char *root, const char *name)
size_t len = strlen(root) + strlen(name) + 2;
char *ret = malloc(len);
if (name)
snprintf(ret, len, "%s/%s", root, name);
snprintf(ret, len, "%s/%s", root, name);
return ret;
}
@ -70,8 +69,7 @@ char *cg_name_indexed(const char *root, const char *name, int index)
size_t len = strlen(root) + strlen(name) + 10;
char *ret = malloc(len);
if (name)
snprintf(ret, len, "%s/%s_%d", root, name, index);
snprintf(ret, len, "%s/%s_%d", root, name, index);
return ret;
}