x86/irq: Remove x86_io_apic_ops.eoi_ioapic_pin and related interfaces
Now there is no user of x86_io_apic_ops.eoi_ioapic_pin anymore, so remove it. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> Tested-by: Joerg Roedel <jroedel@suse.de> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: David Cohen <david.a.cohen@linux.intel.com> Cc: Sander Eikelenboom <linux@eikelenboom.it> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Tony Luck <tony.luck@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: iommu@lists.linux-foundation.org Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Yinghai Lu <yinghai@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Dimitri Sivanich <sivanich@sgi.com> Cc: Joerg Roedel <joro@8bytes.org> Cc: Yijing Wang <wangyijing@huawei.com> Cc: Grant Likely <grant.likely@linaro.org> Link: http://lkml.kernel.org/r/1428978610-28986-7-git-send-email-jiang.liu@linux.intel.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
parent
aa5cb97f14
commit
ad66e1efc9
|
@ -150,10 +150,6 @@ struct irq_cfg;
|
|||
extern void ioapic_insert_resources(void);
|
||||
extern int arch_early_ioapic_init(void);
|
||||
|
||||
extern void eoi_ioapic_irq(unsigned int irq, struct irq_cfg *cfg);
|
||||
|
||||
extern void native_eoi_ioapic_pin(int apic, int pin, int vector);
|
||||
|
||||
extern int save_ioapic_entries(void);
|
||||
extern void mask_ioapic_entries(void);
|
||||
extern int restore_ioapic_entries(void);
|
||||
|
@ -237,8 +233,6 @@ static inline void io_apic_modify(unsigned int apic, unsigned int reg, unsigned
|
|||
x86_io_apic_ops.modify(apic, reg, value);
|
||||
}
|
||||
|
||||
extern void io_apic_eoi(unsigned int apic, unsigned int vector);
|
||||
|
||||
extern void setup_IO_APIC(void);
|
||||
extern void enable_IO_APIC(void);
|
||||
extern void disable_IO_APIC(void);
|
||||
|
@ -282,7 +276,6 @@ static inline void disable_ioapic_support(void) { }
|
|||
#define native_io_apic_write NULL
|
||||
#define native_io_apic_modify NULL
|
||||
#define native_disable_io_apic NULL
|
||||
#define native_eoi_ioapic_pin NULL
|
||||
|
||||
static inline void setup_IO_APIC(void) { }
|
||||
static inline void enable_IO_APIC(void) { }
|
||||
|
|
|
@ -191,7 +191,6 @@ struct x86_io_apic_ops {
|
|||
void (*write) (unsigned int apic, unsigned int reg, unsigned int value);
|
||||
void (*modify) (unsigned int apic, unsigned int reg, unsigned int value);
|
||||
void (*disable)(void);
|
||||
void (*eoi_ioapic_pin)(int apic, int pin, int vector);
|
||||
};
|
||||
|
||||
extern struct x86_init_ops x86_init;
|
||||
|
|
|
@ -271,7 +271,7 @@ static __attribute_const__ struct io_apic __iomem *io_apic_base(int idx)
|
|||
+ (mpc_ioapic_addr(idx) & ~PAGE_MASK);
|
||||
}
|
||||
|
||||
void io_apic_eoi(unsigned int apic, unsigned int vector)
|
||||
static inline void io_apic_eoi(unsigned int apic, unsigned int vector)
|
||||
{
|
||||
struct io_apic __iomem *io_apic = io_apic_base(apic);
|
||||
writel(vector, &io_apic->eoi);
|
||||
|
@ -527,7 +527,7 @@ static void unmask_ioapic_irq(struct irq_data *data)
|
|||
* Otherwise, we simulate the EOI message manually by changing the trigger
|
||||
* mode to edge and then back to level, with RTE being masked during this.
|
||||
*/
|
||||
void native_eoi_ioapic_pin(int apic, int pin, int vector)
|
||||
static void __eoi_ioapic_pin(int apic, int pin, int vector)
|
||||
{
|
||||
if (mpc_ioapic_ver(apic) >= 0x20) {
|
||||
io_apic_eoi(apic, vector);
|
||||
|
@ -558,19 +558,7 @@ void eoi_ioapic_pin(int vector, struct irq_cfg *cfg)
|
|||
|
||||
raw_spin_lock_irqsave(&ioapic_lock, flags);
|
||||
for_each_irq_pin(entry, cfg->irq_2_pin)
|
||||
native_eoi_ioapic_pin(entry->apic, entry->pin, vector);
|
||||
raw_spin_unlock_irqrestore(&ioapic_lock, flags);
|
||||
}
|
||||
|
||||
void eoi_ioapic_irq(unsigned int irq, struct irq_cfg *cfg)
|
||||
{
|
||||
struct irq_pin_list *entry;
|
||||
unsigned long flags;
|
||||
|
||||
raw_spin_lock_irqsave(&ioapic_lock, flags);
|
||||
for_each_irq_pin(entry, cfg->irq_2_pin)
|
||||
x86_io_apic_ops.eoi_ioapic_pin(entry->apic, entry->pin,
|
||||
cfg->vector);
|
||||
__eoi_ioapic_pin(entry->apic, entry->pin, vector);
|
||||
raw_spin_unlock_irqrestore(&ioapic_lock, flags);
|
||||
}
|
||||
|
||||
|
@ -606,7 +594,7 @@ static void clear_IO_APIC_pin(unsigned int apic, unsigned int pin)
|
|||
ioapic_write_entry(apic, pin, entry);
|
||||
}
|
||||
raw_spin_lock_irqsave(&ioapic_lock, flags);
|
||||
native_eoi_ioapic_pin(apic, pin, entry.vector);
|
||||
__eoi_ioapic_pin(apic, pin, entry.vector);
|
||||
raw_spin_unlock_irqrestore(&ioapic_lock, flags);
|
||||
}
|
||||
|
||||
|
|
|
@ -144,5 +144,4 @@ struct x86_io_apic_ops x86_io_apic_ops = {
|
|||
.write = native_io_apic_write,
|
||||
.modify = native_io_apic_modify,
|
||||
.disable = native_disable_io_apic,
|
||||
.eoi_ioapic_pin = native_eoi_ioapic_pin,
|
||||
};
|
||||
|
|
|
@ -43,21 +43,9 @@ static void irq_remapping_disable_io_apic(void)
|
|||
disconnect_bsp_APIC(0);
|
||||
}
|
||||
|
||||
static void eoi_ioapic_pin_remapped(int apic, int pin, int vector)
|
||||
{
|
||||
/*
|
||||
* Intr-remapping uses pin number as the virtual vector
|
||||
* in the RTE. Actual vector is programmed in
|
||||
* intr-remapping table entry. Hence for the io-apic
|
||||
* EOI we use the pin number.
|
||||
*/
|
||||
io_apic_eoi(apic, pin);
|
||||
}
|
||||
|
||||
static void __init irq_remapping_modify_x86_ops(void)
|
||||
{
|
||||
x86_io_apic_ops.disable = irq_remapping_disable_io_apic;
|
||||
x86_io_apic_ops.eoi_ioapic_pin = eoi_ioapic_pin_remapped;
|
||||
}
|
||||
|
||||
static __init int setup_nointremap(char *str)
|
||||
|
@ -171,12 +159,6 @@ void ir_ack_apic_edge(struct irq_data *data)
|
|||
ack_APIC_irq();
|
||||
}
|
||||
|
||||
static void ir_ack_apic_level(struct irq_data *data)
|
||||
{
|
||||
ack_APIC_irq();
|
||||
eoi_ioapic_irq(data->irq, irqd_cfg(data));
|
||||
}
|
||||
|
||||
static void ir_print_prefix(struct irq_data *data, struct seq_file *p)
|
||||
{
|
||||
seq_printf(p, " IR-%s", data->chip->name);
|
||||
|
@ -186,7 +168,6 @@ void irq_remap_modify_chip_defaults(struct irq_chip *chip)
|
|||
{
|
||||
chip->irq_print_chip = ir_print_prefix;
|
||||
chip->irq_ack = ir_ack_apic_edge;
|
||||
chip->irq_eoi = ir_ack_apic_level;
|
||||
}
|
||||
|
||||
bool setup_remapped_irq(int irq, struct irq_cfg *cfg, struct irq_chip *chip)
|
||||
|
|
Loading…
Reference in New Issue