net: sched: extend TCA_ACT space with TCA_ACT_FLAGS
Extend TCA_ACT space with nla_bitfield32 flags. Add TCA_ACT_FLAGS_NO_PERCPU_STATS as the only allowed flag. Parse the flags in tcf_action_init_1() and pass resulting value as additional argument to a_o->init(). Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
5e174d5e73
commit
abbb0d3363
|
@ -94,7 +94,7 @@ struct tc_action_ops {
|
|||
int (*init)(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **act, int ovr,
|
||||
int bind, bool rtnl_held, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack);
|
||||
u32 flags, struct netlink_ext_ack *extack);
|
||||
int (*walk)(struct net *, struct sk_buff *,
|
||||
struct netlink_callback *, int,
|
||||
const struct tc_action_ops *,
|
||||
|
|
|
@ -16,9 +16,14 @@ enum {
|
|||
TCA_ACT_STATS,
|
||||
TCA_ACT_PAD,
|
||||
TCA_ACT_COOKIE,
|
||||
TCA_ACT_FLAGS,
|
||||
__TCA_ACT_MAX
|
||||
};
|
||||
|
||||
#define TCA_ACT_FLAGS_NO_PERCPU_STATS 1 /* Don't use percpu allocator for
|
||||
* actions stats.
|
||||
*/
|
||||
|
||||
#define TCA_ACT_MAX __TCA_ACT_MAX
|
||||
#define TCA_OLD_COMPAT (TCA_ACT_MAX+1)
|
||||
#define TCA_ACT_MAX_PRIO 32
|
||||
|
|
|
@ -831,12 +831,15 @@ static struct tc_cookie *nla_memdup_cookie(struct nlattr **tb)
|
|||
return c;
|
||||
}
|
||||
|
||||
static const u32 tca_act_flags_allowed = TCA_ACT_FLAGS_NO_PERCPU_STATS;
|
||||
static const struct nla_policy tcf_action_policy[TCA_ACT_MAX + 1] = {
|
||||
[TCA_ACT_KIND] = { .type = NLA_STRING },
|
||||
[TCA_ACT_INDEX] = { .type = NLA_U32 },
|
||||
[TCA_ACT_COOKIE] = { .type = NLA_BINARY,
|
||||
.len = TC_COOKIE_MAX_SIZE },
|
||||
[TCA_ACT_OPTIONS] = { .type = NLA_NESTED },
|
||||
[TCA_ACT_FLAGS] = { .type = NLA_BITFIELD32,
|
||||
.validation_data = &tca_act_flags_allowed },
|
||||
};
|
||||
|
||||
struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
|
||||
|
@ -845,6 +848,7 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
|
|||
bool rtnl_held,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct nla_bitfield32 flags = { 0, 0 };
|
||||
struct tc_action *a;
|
||||
struct tc_action_ops *a_o;
|
||||
struct tc_cookie *cookie = NULL;
|
||||
|
@ -876,6 +880,8 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
|
|||
goto err_out;
|
||||
}
|
||||
}
|
||||
if (tb[TCA_ACT_FLAGS])
|
||||
flags = nla_get_bitfield32(tb[TCA_ACT_FLAGS]);
|
||||
} else {
|
||||
if (strlcpy(act_name, name, IFNAMSIZ) >= IFNAMSIZ) {
|
||||
NL_SET_ERR_MSG(extack, "TC action name too long");
|
||||
|
@ -914,10 +920,10 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
|
|||
/* backward compatibility for policer */
|
||||
if (name == NULL)
|
||||
err = a_o->init(net, tb[TCA_ACT_OPTIONS], est, &a, ovr, bind,
|
||||
rtnl_held, tp, extack);
|
||||
rtnl_held, tp, flags.value, extack);
|
||||
else
|
||||
err = a_o->init(net, nla, est, &a, ovr, bind, rtnl_held,
|
||||
tp, extack);
|
||||
tp, flags.value, extack);
|
||||
if (err < 0)
|
||||
goto err_mod;
|
||||
|
||||
|
|
|
@ -275,7 +275,8 @@ static void tcf_bpf_prog_fill_cfg(const struct tcf_bpf *prog,
|
|||
static int tcf_bpf_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **act,
|
||||
int replace, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, bpf_net_id);
|
||||
struct nlattr *tb[TCA_ACT_BPF_MAX + 1];
|
||||
|
|
|
@ -94,7 +94,7 @@ static const struct nla_policy connmark_policy[TCA_CONNMARK_MAX + 1] = {
|
|||
static int tcf_connmark_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, connmark_net_id);
|
||||
|
|
|
@ -43,7 +43,7 @@ static struct tc_action_ops act_csum_ops;
|
|||
static int tcf_csum_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a, int ovr,
|
||||
int bind, bool rtnl_held, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, csum_net_id);
|
||||
struct tcf_csum_params *params_new;
|
||||
|
|
|
@ -656,7 +656,7 @@ static int tcf_ct_fill_params(struct net *net,
|
|||
static int tcf_ct_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int replace, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, ct_net_id);
|
||||
|
|
|
@ -153,7 +153,7 @@ static const struct nla_policy ctinfo_policy[TCA_CTINFO_MAX + 1] = {
|
|||
static int tcf_ctinfo_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, ctinfo_net_id);
|
||||
|
|
|
@ -53,7 +53,8 @@ static const struct nla_policy gact_policy[TCA_GACT_MAX + 1] = {
|
|||
static int tcf_gact_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, gact_net_id);
|
||||
struct nlattr *tb[TCA_GACT_MAX + 1];
|
||||
|
|
|
@ -465,7 +465,8 @@ static int populate_metalist(struct tcf_ife_info *ife, struct nlattr **tb,
|
|||
static int tcf_ife_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, ife_net_id);
|
||||
struct nlattr *tb[TCA_IFE_MAX + 1];
|
||||
|
|
|
@ -95,7 +95,7 @@ static const struct nla_policy ipt_policy[TCA_IPT_MAX + 1] = {
|
|||
static int __tcf_ipt_init(struct net *net, unsigned int id, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
const struct tc_action_ops *ops, int ovr, int bind,
|
||||
struct tcf_proto *tp)
|
||||
struct tcf_proto *tp, u32 flags)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, id);
|
||||
struct nlattr *tb[TCA_IPT_MAX + 1];
|
||||
|
@ -205,19 +205,19 @@ err1:
|
|||
static int tcf_ipt_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a, int ovr,
|
||||
int bind, bool rtnl_held, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
return __tcf_ipt_init(net, ipt_net_id, nla, est, a, &act_ipt_ops, ovr,
|
||||
bind, tp);
|
||||
bind, tp, flags);
|
||||
}
|
||||
|
||||
static int tcf_xt_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a, int ovr,
|
||||
int bind, bool unlocked, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
return __tcf_ipt_init(net, xt_net_id, nla, est, a, &act_xt_ops, ovr,
|
||||
bind, tp);
|
||||
bind, tp, flags);
|
||||
}
|
||||
|
||||
static int tcf_ipt_act(struct sk_buff *skb, const struct tc_action *a,
|
||||
|
|
|
@ -93,7 +93,7 @@ static int tcf_mirred_init(struct net *net, struct nlattr *nla,
|
|||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, mirred_net_id);
|
||||
struct nlattr *tb[TCA_MIRRED_MAX + 1];
|
||||
|
|
|
@ -131,7 +131,8 @@ static const struct nla_policy mpls_policy[TCA_MPLS_MAX + 1] = {
|
|||
static int tcf_mpls_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, mpls_net_id);
|
||||
struct nlattr *tb[TCA_MPLS_MAX + 1];
|
||||
|
|
|
@ -36,7 +36,7 @@ static const struct nla_policy nat_policy[TCA_NAT_MAX + 1] = {
|
|||
static int tcf_nat_init(struct net *net, struct nlattr *nla, struct nlattr *est,
|
||||
struct tc_action **a, int ovr, int bind,
|
||||
bool rtnl_held, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, nat_net_id);
|
||||
struct nlattr *tb[TCA_NAT_MAX + 1];
|
||||
|
|
|
@ -137,7 +137,8 @@ nla_failure:
|
|||
static int tcf_pedit_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, pedit_net_id);
|
||||
struct nlattr *tb[TCA_PEDIT_MAX + 1];
|
||||
|
|
|
@ -47,7 +47,7 @@ static const struct nla_policy police_policy[TCA_POLICE_MAX + 1] = {
|
|||
static int tcf_police_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
int ret = 0, tcfp_result = TC_ACT_OK, err, size;
|
||||
|
|
|
@ -36,7 +36,7 @@ static const struct nla_policy sample_policy[TCA_SAMPLE_MAX + 1] = {
|
|||
static int tcf_sample_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a, int ovr,
|
||||
int bind, bool rtnl_held, struct tcf_proto *tp,
|
||||
struct netlink_ext_ack *extack)
|
||||
u32 flags, struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, sample_net_id);
|
||||
struct nlattr *tb[TCA_SAMPLE_MAX + 1];
|
||||
|
|
|
@ -86,7 +86,8 @@ static const struct nla_policy simple_policy[TCA_DEF_MAX + 1] = {
|
|||
static int tcf_simp_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, simp_net_id);
|
||||
struct nlattr *tb[TCA_DEF_MAX + 1];
|
||||
|
|
|
@ -86,7 +86,7 @@ static const struct nla_policy skbedit_policy[TCA_SKBEDIT_MAX + 1] = {
|
|||
static int tcf_skbedit_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 act_flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, skbedit_net_id);
|
||||
|
|
|
@ -79,7 +79,7 @@ static const struct nla_policy skbmod_policy[TCA_SKBMOD_MAX + 1] = {
|
|||
static int tcf_skbmod_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, skbmod_net_id);
|
||||
|
|
|
@ -208,7 +208,7 @@ static void tunnel_key_release_params(struct tcf_tunnel_key_params *p)
|
|||
static int tunnel_key_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp,
|
||||
struct tcf_proto *tp, u32 act_flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, tunnel_key_net_id);
|
||||
|
|
|
@ -102,7 +102,8 @@ static const struct nla_policy vlan_policy[TCA_VLAN_MAX + 1] = {
|
|||
static int tcf_vlan_init(struct net *net, struct nlattr *nla,
|
||||
struct nlattr *est, struct tc_action **a,
|
||||
int ovr, int bind, bool rtnl_held,
|
||||
struct tcf_proto *tp, struct netlink_ext_ack *extack)
|
||||
struct tcf_proto *tp, u32 flags,
|
||||
struct netlink_ext_ack *extack)
|
||||
{
|
||||
struct tc_action_net *tn = net_generic(net, vlan_net_id);
|
||||
struct nlattr *tb[TCA_VLAN_MAX + 1];
|
||||
|
|
Loading…
Reference in New Issue