net: ppp_generic - use DEFINE_IDR for static initialization
We could use DEFINE_IDR for statically allocated idr that allow us to save a few lines of code. And spell fix. Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
a109a5b916
commit
ab5024ab23
|
@ -179,7 +179,7 @@ struct channel {
|
|||
*/
|
||||
static DEFINE_MUTEX(all_ppp_mutex);
|
||||
static atomic_t ppp_unit_count = ATOMIC_INIT(0);
|
||||
static struct idr ppp_units_idr;
|
||||
static DEFINE_IDR(ppp_units_idr);
|
||||
|
||||
/*
|
||||
* all_channels_lock protects all_channels and last_channel_index,
|
||||
|
@ -852,8 +852,6 @@ static int __init ppp_init(void)
|
|||
"ppp");
|
||||
}
|
||||
|
||||
idr_init(&ppp_units_idr);
|
||||
|
||||
out:
|
||||
if (err)
|
||||
printk(KERN_ERR "failed to register PPP device (%d)\n", err);
|
||||
|
@ -2435,7 +2433,7 @@ ppp_create_interface(int unit, int *retp)
|
|||
if (unit_find(&ppp_units_idr, unit))
|
||||
goto out2; /* unit already exists */
|
||||
else {
|
||||
/* darn, someone is cheatting us? */
|
||||
/* darn, someone is cheating us? */
|
||||
*retp = -EINVAL;
|
||||
goto out2;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue