hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging:iio:magnetometer:ak8975 drop I2C_M_NOSTART flag in read_data 

This flag makes no sense whatsoever where it is.
Documentation/i2c/i2c-protocol states:

  If you set the I2C_M_NOSTART variable for the first partial message,
  we do not generate Addr, but we do generate the startbit S. This will
  probably confuse all other clients on your bus, so don't try this.

This is exactly what is going on here.  Likelihood given that the
driver never checked for this protocol mangling being available is that
it wasn't present on the test boards and hence this flag was simply
ignored.  No indication of why it would be necessary has been found in
the datasheets.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
This commit is contained in:
Jonathan Cameron 2013-03-24 16:58:00 +00:00
parent dea120e665
commit aa9922579f
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/iio/magnetometer/ak8975.c
View File

@ -132,7 +132,6 @@ static int ak8975_read_data(struct i2c_client *client,
struct i2c_msg msg[2] = { struct i2c_msg msg[2] = {
{ {
.addr = client->addr, .addr = client->addr,
.flags = I2C_M_NOSTART,
.len = 1, .len = 1,
.buf = &reg, .buf = &reg,
}, { }, {