hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: addi_eeprom: cleanup i_EepromReadMainHeader() 

Add namespace by renaming this CamelCase function to
addi_eeprom_read_info().

Remove the 'type' parameter. This parameter is a char pointer to the
string name of the eeprom type used on the board. This can be found
when needed using the dev pointer.

Change the parameter order so that the comedi_device pointer is passed
first.

The return value is always 0 and it's never checked. Change it to void.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-10-29 17:09:11 -07:00 committed by Greg Kroah-Hartman
parent 6f98fe207b
commit a927077c62
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/comedi/drivers/addi-data/addi_common.c
View File

@ -217,8 +217,7 @@ static int i_ADDI_Attach(struct comedi_device *dev, struct comedi_devconfig *it)
printk("\nEnable the interrupt for the controller");
}
printk("\nRead Eeprom");
i_EepromReadMainHeader(io_addr[0], this_board->pc_EepromChip,
dev);
addi_eeprom_read_info(dev, io_addr[0]);
} else {
printk("\nPCI Eeprom unused");
}

9
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c
View File

@ -328,10 +328,11 @@ static void addi_eeprom_read_ai_info(struct comedi_device *dev,
devpriv->s_EeParameters.i_AiMaxdata = 0xffff >> (16 - tmp);
}
static int i_EepromReadMainHeader(unsigned long iobase,
char *type,
struct comedi_device *dev)
static void addi_eeprom_read_info(struct comedi_device *dev,
unsigned long iobase)
{
const struct addi_board *this_board = comedi_board(dev);
char *type = this_board->pc_EepromChip;
unsigned short size;
unsigned char nfuncs;
int i;
@ -372,6 +373,4 @@ static int i_EepromReadMainHeader(unsigned long iobase,
break;
}
}
return 0;
}