hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: gasket: sysfs: clean up state if ENOMEM removing mapping 

If kcalloc() returns NULL in put_mapping(), continue to clean up state,
including dropping the reference on the struct device and free attribute
memory.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Todd Poynor 2018-08-05 13:07:35 -07:00 committed by Greg Kroah-Hartman
parent 2bc7596438
commit a81d678949
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/gasket/gasket_sysfs.c
View File

@ -101,13 +101,12 @@ static void put_mapping(struct gasket_sysfs_mapping *mapping)
files_to_remove = kcalloc(num_files_to_remove,
sizeof(*files_to_remove),
GFP_KERNEL);
if (!files_to_remove) {
mutex_unlock(&mapping->mutex);
return;
}
for (i = 0; i < num_files_to_remove; i++)
files_to_remove[i] = mapping->attributes[i].attr;
if (files_to_remove)
for (i = 0; i < num_files_to_remove; i++)
files_to_remove[i] =
mapping->attributes[i].attr;
else
num_files_to_remove = 0;
kfree(mapping->attributes);
mapping->attributes = NULL;