hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drm/scheduler: add NULL pointer check for run queue (v2) 

To check rq pointer before adding entity into it.
That avoids NULL pointer access in some case.

v2: move the check to caller

Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Junwei Zhang 2018-07-16 10:53:43 +08:00 committed by Alex Deucher
parent 964d0fbf63
commit a6da48caf9
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/scheduler/gpu_scheduler.c
View File

@ -547,6 +547,11 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job,
if (first) { if (first) {
/* Add the entity to the run queue */ /* Add the entity to the run queue */
spin_lock(&entity->rq_lock); spin_lock(&entity->rq_lock);
if (!entity->rq) {
DRM_ERROR("Trying to push to a killed entity\n");
spin_unlock(&entity->rq_lock);
return;
}
drm_sched_rq_add_entity(entity->rq, entity); drm_sched_rq_add_entity(entity->rq, entity);
spin_unlock(&entity->rq_lock); spin_unlock(&entity->rq_lock);
drm_sched_wakeup(sched); drm_sched_wakeup(sched);