scripts/decode_stacktrace: warn when modpath is needed but is unset
When a user tries to parse a symbol located inside a module he must have modpath set. Otherwise, decode_stacktrace won't be able to parse the symbol correctly. Right now the failure is silent and easily missed by the user. What's worse is that by the time the user realizes what happened (or someone on LKML asks him to add the modpath and re-run), he might have already got rid of the vmlinux/modules. Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
3be20b6fc1
commit
a5dc8300df
|
@ -27,7 +27,10 @@ parse_symbol() {
|
|||
elif [[ "${modcache[$module]+isset}" == "isset" ]]; then
|
||||
local objfile=${modcache[$module]}
|
||||
else
|
||||
[[ $modpath == "" ]] && return
|
||||
if [[ $modpath == "" ]]; then
|
||||
echo "WARNING! Modules path isn't set, but is needed to parse this symbol" >&2
|
||||
return
|
||||
fi
|
||||
local objfile=$(find "$modpath" -name "${module//_/[-_]}.ko*" -print -quit)
|
||||
[[ $objfile == "" ]] && return
|
||||
modcache[$module]=$objfile
|
||||
|
|
Loading…
Reference in New Issue