crypto: af_alg - Fix socket double-free when accept fails
When we fail an accept(2) call we will end up freeing the socket twice, once due to the direct sk_free call and once again through newsock. This patch fixes this by removing the sk_free call. Cc: stable@vger.kernel.org Reported-by: Dmitry Vyukov <dvyukov@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
c840ac6af3
commit
a383292c86
|
@ -285,10 +285,8 @@ int af_alg_accept(struct sock *sk, struct socket *newsock)
|
||||||
security_sk_clone(sk, sk2);
|
security_sk_clone(sk, sk2);
|
||||||
|
|
||||||
err = type->accept(ask->private, sk2);
|
err = type->accept(ask->private, sk2);
|
||||||
if (err) {
|
if (err)
|
||||||
sk_free(sk2);
|
|
||||||
goto unlock;
|
goto unlock;
|
||||||
}
|
|
||||||
|
|
||||||
sk2->sk_family = PF_ALG;
|
sk2->sk_family = PF_ALG;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue