IPoIB: Close race in ipoib_flush_paths()
ib_sa_cancel_query() must be called with priv->lock held since a completion might arrive and set path->query to NULL. Signed-off-by: Eli Cohen <eli@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
parent
abf45dbb5b
commit
a30bb96c6f
|
@ -346,14 +346,15 @@ void ipoib_flush_paths(struct net_device *dev)
|
|||
list_for_each_entry(path, &remove_list, list)
|
||||
rb_erase(&path->rb_node, &priv->path_tree);
|
||||
|
||||
spin_unlock_irqrestore(&priv->lock, flags);
|
||||
|
||||
list_for_each_entry_safe(path, tp, &remove_list, list) {
|
||||
if (path->query)
|
||||
ib_sa_cancel_query(path->query_id, path->query);
|
||||
spin_unlock_irqrestore(&priv->lock, flags);
|
||||
wait_for_completion(&path->done);
|
||||
path_free(dev, path);
|
||||
spin_lock_irqsave(&priv->lock, flags);
|
||||
}
|
||||
spin_unlock_irqrestore(&priv->lock, flags);
|
||||
}
|
||||
|
||||
static void path_rec_completion(int status,
|
||||
|
|
Loading…
Reference in New Issue