hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

KVM: Fix xsave and xcr save/restore memory leak 

We allocate temporary kernel buffers for these structures, but never free them.

Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
Avi Kivity 2010-06-20 15:47:34 +03:00
parent 7d5993d63f
commit a1a005f36e
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/x86/kvm/x86.c
View File

@ -2437,6 +2437,8 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
void __user *argp = (void __user *)arg; void __user *argp = (void __user *)arg;
int r; int r;
struct kvm_lapic_state *lapic = NULL; struct kvm_lapic_state *lapic = NULL;
struct kvm_xsave *xsave = NULL;
struct kvm_xcrs *xcrs = NULL;
switch (ioctl) { switch (ioctl) {
case KVM_GET_LAPIC: { case KVM_GET_LAPIC: {
@ -2632,8 +2634,6 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
break; break;
} }
case KVM_GET_XSAVE: { case KVM_GET_XSAVE: {
struct kvm_xsave *xsave;
xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL); xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL);
r = -ENOMEM; r = -ENOMEM;
if (!xsave) if (!xsave)
@ -2648,8 +2648,6 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
break; break;
} }
case KVM_SET_XSAVE: { case KVM_SET_XSAVE: {
struct kvm_xsave *xsave;
xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL); xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL);
r = -ENOMEM; r = -ENOMEM;
if (!xsave) if (!xsave)
@ -2663,8 +2661,6 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
break; break;
} }
case KVM_GET_XCRS: { case KVM_GET_XCRS: {
struct kvm_xcrs *xcrs;
xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL); xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL);
r = -ENOMEM; r = -ENOMEM;
if (!xcrs) if (!xcrs)
@ -2680,8 +2676,6 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
break; break;
} }
case KVM_SET_XCRS: { case KVM_SET_XCRS: {
struct kvm_xcrs *xcrs;
xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL); xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL);
r = -ENOMEM; r = -ENOMEM;
if (!xcrs) if (!xcrs)
@ -2700,6 +2694,8 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
} }
out: out:
kfree(lapic); kfree(lapic);
kfree(xsave);
kfree(xcrs);
return r; return r;
} }