kernel/kexec.c: use vscnprintf() instead of vsnprintf() in vmcoreinfo_append_str()
vsnprintf() may let 'r' larger than sizeof(buf), in this case, if 'r' is also less than "vmcoreinfo_max_size - vmcoreinfo_size" (left size of destination buffer), next memcpy() will read the unexpected addresses. Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
53e0ee9fc5
commit
a19428e5c3
|
@ -1537,7 +1537,7 @@ void vmcoreinfo_append_str(const char *fmt, ...)
|
||||||
size_t r;
|
size_t r;
|
||||||
|
|
||||||
va_start(args, fmt);
|
va_start(args, fmt);
|
||||||
r = vsnprintf(buf, sizeof(buf), fmt, args);
|
r = vscnprintf(buf, sizeof(buf), fmt, args);
|
||||||
va_end(args);
|
va_end(args);
|
||||||
|
|
||||||
r = min(r, vmcoreinfo_max_size - vmcoreinfo_size);
|
r = min(r, vmcoreinfo_max_size - vmcoreinfo_size);
|
||||||
|
|
Loading…
Reference in New Issue