hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iop-adma, mv_xor: fix mem leak on self-test setup failure 

iop_adma_zero_sum_self_test has the brackets in the wrong place for the
setup failure deallocation path.  This error was duplicated in
mv_xor_xor_self_test.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Roel Kluin 2009-02-25 13:56:21 +01:00 committed by Dan Williams
parent 900325a6ce
commit a09b09ae51
2 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/dma/iop-adma.c
View File

@ -928,16 +928,16 @@ iop_adma_xor_zero_sum_self_test(struct iop_adma_device *device)
for (src_idx = 0; src_idx < IOP_ADMA_NUM_SRC_TEST; src_idx++) { for (src_idx = 0; src_idx < IOP_ADMA_NUM_SRC_TEST; src_idx++) {
xor_srcs[src_idx] = alloc_page(GFP_KERNEL); xor_srcs[src_idx] = alloc_page(GFP_KERNEL);
if (!xor_srcs[src_idx]) if (!xor_srcs[src_idx]) {
while (src_idx--) { while (src_idx--)
__free_page(xor_srcs[src_idx]); __free_page(xor_srcs[src_idx]);
return -ENOMEM; return -ENOMEM;
} }
} }
dest = alloc_page(GFP_KERNEL); dest = alloc_page(GFP_KERNEL);
if (!dest) if (!dest) {
while (src_idx--) { while (src_idx--)
__free_page(xor_srcs[src_idx]); __free_page(xor_srcs[src_idx]);
return -ENOMEM; return -ENOMEM;
} }

8
drivers/dma/mv_xor.c
View File

@ -1019,16 +1019,16 @@ mv_xor_xor_self_test(struct mv_xor_device *device)
for (src_idx = 0; src_idx < MV_XOR_NUM_SRC_TEST; src_idx++) { for (src_idx = 0; src_idx < MV_XOR_NUM_SRC_TEST; src_idx++) {
xor_srcs[src_idx] = alloc_page(GFP_KERNEL); xor_srcs[src_idx] = alloc_page(GFP_KERNEL);
if (!xor_srcs[src_idx]) if (!xor_srcs[src_idx]) {
while (src_idx--) { while (src_idx--)
__free_page(xor_srcs[src_idx]); __free_page(xor_srcs[src_idx]);
return -ENOMEM; return -ENOMEM;
} }
} }
dest = alloc_page(GFP_KERNEL); dest = alloc_page(GFP_KERNEL);
if (!dest) if (!dest) {
while (src_idx--) { while (src_idx--)
__free_page(xor_srcs[src_idx]); __free_page(xor_srcs[src_idx]);
return -ENOMEM; return -ENOMEM;
} }