ipv4: Introduce IN_DEV_NET_ROUTE_LOCALNET
performance profiles show a high cost in the IN_DEV_ROUTE_LOCALNET() call done in ip_route_input_slow(), because of multiple dereferences, even if cache lines are clean and available in cpu caches. Since we already have the 'net' pointer, introduce IN_DEV_NET_ROUTE_LOCALNET() macro avoiding two dereferences (dev_net(in_dev->dev)) Also change the tests to use IN_DEV_NET_ROUTE_LOCALNET() only if saddr or/and daddr are loopback addresse. Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
40384999d1
commit
9eb43e7653
|
@ -104,9 +104,14 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev)
|
|||
#define IN_DEV_ANDCONF(in_dev, attr) \
|
||||
(IPV4_DEVCONF_ALL(dev_net(in_dev->dev), attr) && \
|
||||
IN_DEV_CONF_GET((in_dev), attr))
|
||||
#define IN_DEV_ORCONF(in_dev, attr) \
|
||||
(IPV4_DEVCONF_ALL(dev_net(in_dev->dev), attr) || \
|
||||
|
||||
#define IN_DEV_NET_ORCONF(in_dev, net, attr) \
|
||||
(IPV4_DEVCONF_ALL(net, attr) || \
|
||||
IN_DEV_CONF_GET((in_dev), attr))
|
||||
|
||||
#define IN_DEV_ORCONF(in_dev, attr) \
|
||||
IN_DEV_NET_ORCONF(in_dev, dev_net(in_dev->dev), attr)
|
||||
|
||||
#define IN_DEV_MAXCONF(in_dev, attr) \
|
||||
(max(IPV4_DEVCONF_ALL(dev_net(in_dev->dev), attr), \
|
||||
IN_DEV_CONF_GET((in_dev), attr)))
|
||||
|
@ -133,6 +138,8 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev)
|
|||
IN_DEV_ORCONF((in_dev), \
|
||||
PROMOTE_SECONDARIES)
|
||||
#define IN_DEV_ROUTE_LOCALNET(in_dev) IN_DEV_ORCONF(in_dev, ROUTE_LOCALNET)
|
||||
#define IN_DEV_NET_ROUTE_LOCALNET(in_dev, net) \
|
||||
IN_DEV_NET_ORCONF(in_dev, net, ROUTE_LOCALNET)
|
||||
|
||||
#define IN_DEV_RX_REDIRECTS(in_dev) \
|
||||
((IN_DEV_FORWARD(in_dev) && \
|
||||
|
|
|
@ -1587,11 +1587,14 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
|
|||
if (ipv4_is_zeronet(daddr))
|
||||
goto martian_destination;
|
||||
|
||||
if (likely(!IN_DEV_ROUTE_LOCALNET(in_dev))) {
|
||||
if (ipv4_is_loopback(daddr))
|
||||
/* Following code try to avoid calling IN_DEV_NET_ROUTE_LOCALNET(),
|
||||
* and call it once if daddr or/and saddr are loopback addresses
|
||||
*/
|
||||
if (ipv4_is_loopback(daddr)) {
|
||||
if (!IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
|
||||
goto martian_destination;
|
||||
|
||||
if (ipv4_is_loopback(saddr))
|
||||
} else if (ipv4_is_loopback(saddr)) {
|
||||
if (!IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
|
||||
goto martian_source;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue