Revert "gpiolib: request the gpio before querying its direction"
This reverts commit 108d23e322
.
It turns out this causes a regression on the OMAP, Marvell
and Renesas.
Reported-by: Tony Lindgren <tony@atomide.com>
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
1253baaaff
commit
9e238e380c
|
@ -1221,14 +1221,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
|
|||
struct gpio_desc *desc = &gdev->descs[i];
|
||||
|
||||
desc->gdev = gdev;
|
||||
|
||||
if (chip->request) {
|
||||
status = chip->request(chip, i);
|
||||
if (status < 0)
|
||||
/* The GPIO is unavailable, so skip it */
|
||||
continue;
|
||||
}
|
||||
|
||||
/*
|
||||
* REVISIT: most hardware initializes GPIOs as inputs
|
||||
* (often with pullups enabled) so power usage is
|
||||
|
@ -1254,9 +1246,6 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data)
|
|||
*/
|
||||
set_bit(FLAG_IS_OUT, &desc->flags);
|
||||
}
|
||||
|
||||
if (chip->free)
|
||||
chip->free(chip, i);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PINCTRL
|
||||
|
|
Loading…
Reference in New Issue