[SCSI] bfa: use negative error return values in all functions
Signed-off-by: Krishna Gudipati <kgudipat@brocade.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
parent
7826f304b1
commit
9afbcfab74
|
@ -56,7 +56,7 @@ bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd)
|
||||||
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
spin_lock_irqsave(&bfad->bfad_lock, flags);
|
||||||
if (bfad->disable_active) {
|
if (bfad->disable_active) {
|
||||||
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
|
||||||
return EBUSY;
|
return -EBUSY;
|
||||||
}
|
}
|
||||||
|
|
||||||
bfad->disable_active = BFA_TRUE;
|
bfad->disable_active = BFA_TRUE;
|
||||||
|
@ -390,7 +390,7 @@ bfad_iocmd_lport_get_rports(struct bfad_s *bfad, void *cmd,
|
||||||
void *iocmd_bufptr;
|
void *iocmd_bufptr;
|
||||||
|
|
||||||
if (iocmd->nrports == 0)
|
if (iocmd->nrports == 0)
|
||||||
return EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
if (bfad_chk_iocmd_sz(payload_len,
|
if (bfad_chk_iocmd_sz(payload_len,
|
||||||
sizeof(struct bfa_bsg_lport_get_rports_s),
|
sizeof(struct bfa_bsg_lport_get_rports_s),
|
||||||
|
@ -1516,7 +1516,7 @@ static int
|
||||||
bfad_iocmd_handler(struct bfad_s *bfad, unsigned int cmd, void *iocmd,
|
bfad_iocmd_handler(struct bfad_s *bfad, unsigned int cmd, void *iocmd,
|
||||||
unsigned int payload_len)
|
unsigned int payload_len)
|
||||||
{
|
{
|
||||||
int rc = EINVAL;
|
int rc = -EINVAL;
|
||||||
|
|
||||||
switch (cmd) {
|
switch (cmd) {
|
||||||
case IOCMD_IOC_ENABLE:
|
case IOCMD_IOC_ENABLE:
|
||||||
|
@ -1704,10 +1704,10 @@ bfad_iocmd_handler(struct bfad_s *bfad, unsigned int cmd, void *iocmd,
|
||||||
rc = bfad_iocmd_porglog_get(bfad, iocmd);
|
rc = bfad_iocmd_porglog_get(bfad, iocmd);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rc = EINVAL;
|
rc = -EINVAL;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
return -rc;
|
return rc;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int
|
static int
|
||||||
|
|
Loading…
Reference in New Issue